Antoine Pitrou <pit...@free.fr> added the comment: > My original patch was much more focused, but had a slightly larger > performance penalty for sorting random keys (see > http://bugs.python.org/msg122178). Do you think the performance > tradeoff there was still worthwhile?
I am not objecting against the performance tweaks but the other more or less gratuitous changes (IFLT vs ISLT, Py_LOCAL_INLINE sprinkled all over, weird complicated static "keys" instead of the initial stack_keys, "else" style change...). You can still try to salvage my comments from the review I've posted, but it seems Rietveld makes the thing tediously annoying to navigate (best thing may be to browse all 14 side-by-side diffs to look for the comments). ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue9915> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
