Amaury Forgeot d'Arc <amaur...@gmail.com> added the comment: The patch looks good, I only have stylistic remarks: - We normally don't use windows-specific types in CPython code. Please use int instead of BOOL. And C variables are usually lowercase, even module globals. I suggest something like "static int win32_can_symlink;" - the enable_symlink() function should be "static" as well.
---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue9333> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
