On 21 September 2017 at 03:49, Craig Rodrigues <rodr...@crodrigues.org> wrote: > The references implementation of buildbot is being actively used to build > buildbot > itself, and highlights integration with GitHub Pull Requests:
Just noting that while the PR support in Buildbot 0.9 is definitely a nice feature, we can't use it directly in its current form, as we promise folks contributing workers to the BuildBot fleet that we'll only run approved code on their systems. Since PRs contain *un*approved code, we'd need the Buildbot trigger to be a "test this on the Buildbot fleet" comment from a reviewer with merge privileges, rather than something that happens automatically for every PR. The other reason an approach like that would be better for us is that for the majority of changes, the risk of cross-platform compatibility issues is genuinely low, so it makes more sense to go with pre-merge CI on Linux and Windows, and only run post-merge testing across the entire fleet) Cheers, Nick. -- Nick Coghlan | ncogh...@gmail.com | Brisbane, Australia _______________________________________________ Python-Buildbots mailing list Python-Buildbots@python.org https://mail.python.org/mailman/listinfo/python-buildbots
