https://github.com/python/cpython/commit/27cf3ed00cfe942f4277c273a3dda8ee2ba61fc8
commit: 27cf3ed00cfe942f4277c273a3dda8ee2ba61fc8
branch: main
author: Victor Stinner <vstin...@python.org>
committer: vstinner <vstin...@python.org>
date: 2024-03-19T14:42:44+01:00
summary:
gh-90872: Fix subprocess.Popen.wait() for negative timeout (#116989)
On Windows, subprocess.Popen.wait() no longer calls
WaitForSingleObject() with a negative timeout: pass 0 ms if the
timeout is negative.
files:
A Misc/NEWS.d/next/Library/2024-03-19-11-08-26.gh-issue-90872.ghys95.rst
M Lib/subprocess.py
M Lib/test/test_subprocess.py
diff --git a/Lib/subprocess.py b/Lib/subprocess.py
index 1437bf8148282c..dbe15277866c99 100644
--- a/Lib/subprocess.py
+++ b/Lib/subprocess.py
@@ -1586,6 +1586,8 @@ def _wait(self, timeout):
"""Internal implementation of wait() on Windows."""
if timeout is None:
timeout_millis = _winapi.INFINITE
+ elif timeout <= 0:
+ timeout_millis = 0
else:
timeout_millis = int(timeout * 1000)
if self.returncode is None:
diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py
index c44a778d5bbefe..d20b987961ea6f 100644
--- a/Lib/test/test_subprocess.py
+++ b/Lib/test/test_subprocess.py
@@ -1607,6 +1607,22 @@ def test_class_getitems(self):
self.assertIsInstance(subprocess.Popen[bytes], types.GenericAlias)
self.assertIsInstance(subprocess.CompletedProcess[str],
types.GenericAlias)
+ @unittest.skipUnless(hasattr(subprocess, '_winapi'),
+ 'need subprocess._winapi')
+ def test_wait_negative_timeout(self):
+ proc = subprocess.Popen(ZERO_RETURN_CMD)
+ with proc:
+ patch = mock.patch.object(
+ subprocess._winapi,
+ 'WaitForSingleObject',
+ return_value=subprocess._winapi.WAIT_OBJECT_0)
+ with patch as mock_wait:
+ proc.wait(-1) # negative timeout
+ mock_wait.assert_called_once_with(proc._handle, 0)
+ proc.returncode = None
+
+ self.assertEqual(proc.wait(), 0)
+
class RunFuncTestCase(BaseTestCase):
def run_python(self, code, **kwargs):
diff --git
a/Misc/NEWS.d/next/Library/2024-03-19-11-08-26.gh-issue-90872.ghys95.rst
b/Misc/NEWS.d/next/Library/2024-03-19-11-08-26.gh-issue-90872.ghys95.rst
new file mode 100644
index 00000000000000..ead68caa9fe88b
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2024-03-19-11-08-26.gh-issue-90872.ghys95.rst
@@ -0,0 +1,3 @@
+On Windows, :meth:`subprocess.Popen.wait` no longer calls
+``WaitForSingleObject()`` with a negative timeout: pass ``0`` ms if the
+timeout is negative. Patch by Victor Stinner.
_______________________________________________
Python-checkins mailing list -- python-checkins@python.org
To unsubscribe send an email to python-checkins-le...@python.org
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: arch...@mail-archive.com
