https://github.com/python/cpython/commit/b568c2c1ff5c0b1922a6402dc95c588d7f9aa914
commit: b568c2c1ff5c0b1922a6402dc95c588d7f9aa914
branch: main
author: Erlend E. Aasland <[email protected]>
committer: erlend-aasland <[email protected]>
date: 2024-04-30T19:58:22Z
summary:
gh-118406: Add signature for sqlite3.Connection objects (#118428)
files:
A Misc/NEWS.d/next/Library/2024-04-30-15-18-19.gh-issue-118406.y-GnMo.rst
M Lib/test/test_sqlite3/test_dbapi.py
M Modules/_sqlite/connection.c
diff --git a/Lib/test/test_sqlite3/test_dbapi.py
b/Lib/test/test_sqlite3/test_dbapi.py
index 6d8744ca5f7969..51ce095df41fc1 100644
--- a/Lib/test/test_sqlite3/test_dbapi.py
+++ b/Lib/test/test_sqlite3/test_dbapi.py
@@ -590,6 +590,11 @@ def test_connection_resource_warning(self):
del cx
gc_collect()
+ def test_connection_signature(self):
+ from inspect import signature
+ sig = signature(self.cx)
+ self.assertEqual(str(sig), "(sql, /)")
+
class UninitialisedConnectionTests(unittest.TestCase):
def setUp(self):
diff --git
a/Misc/NEWS.d/next/Library/2024-04-30-15-18-19.gh-issue-118406.y-GnMo.rst
b/Misc/NEWS.d/next/Library/2024-04-30-15-18-19.gh-issue-118406.y-GnMo.rst
new file mode 100644
index 00000000000000..c60ddf9e00498e
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2024-04-30-15-18-19.gh-issue-118406.y-GnMo.rst
@@ -0,0 +1 @@
+Add signature for :class:`sqlite3.Connection` objects.
diff --git a/Modules/_sqlite/connection.c b/Modules/_sqlite/connection.c
index 74984ca5365743..fc03e4a085c179 100644
--- a/Modules/_sqlite/connection.c
+++ b/Modules/_sqlite/connection.c
@@ -2561,6 +2561,12 @@ set_autocommit(pysqlite_Connection *self, PyObject *val,
void *Py_UNUSED(ctx))
return 0;
}
+static PyObject *
+get_sig(PyObject *self, void *Py_UNUSED(ctx))
+{
+ return PyUnicode_FromString("(sql, /)");
+}
+
static const char connection_doc[] =
PyDoc_STR("SQLite database connection object.");
@@ -2570,6 +2576,7 @@ static PyGetSetDef connection_getset[] = {
{"total_changes", (getter)pysqlite_connection_get_total_changes,
(setter)0},
{"in_transaction", (getter)pysqlite_connection_get_in_transaction,
(setter)0},
{"autocommit", (getter)get_autocommit, (setter)set_autocommit},
+ {"__text_signature__", get_sig, (setter)0},
{NULL}
};
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]
