https://github.com/python/cpython/commit/c7c9b913c01afb8d2ff4048f82155969f7ef75b1
commit: c7c9b913c01afb8d2ff4048f82155969f7ef75b1
branch: main
author: Raymond Hettinger <[email protected]>
committer: rhettinger <[email protected]>
date: 2024-05-05T01:42:30-05:00
summary:
gh-118476: Fix corner cases in islice() rough equivalent. (Gh-118559)
files:
M Doc/library/itertools.rst
diff --git a/Doc/library/itertools.rst b/Doc/library/itertools.rst
index 820906085151a3..fb3f33370e3faa 100644
--- a/Doc/library/itertools.rst
+++ b/Doc/library/itertools.rst
@@ -504,24 +504,17 @@ loops that truncate the stream.
# islice('ABCDEFG', 2, None) → C D E F G
# islice('ABCDEFG', 0, None, 2) → A C E G
s = slice(*args)
- start, stop, step = s.start or 0, s.stop or sys.maxsize, s.step or 1
- it = iter(range(start, stop, step))
- try:
- nexti = next(it)
- except StopIteration:
- # Consume *iterable* up to the *start* position.
- for i, element in zip(range(start), iterable):
- pass
- return
- try:
- for i, element in enumerate(iterable):
- if i == nexti:
- yield element
- nexti = next(it)
- except StopIteration:
- # Consume to *stop*.
- for i, element in zip(range(i + 1, stop), iterable):
- pass
+ start = 0 if s.start is None else s.start
+ stop = s.stop
+ step = 1 if s.step is None else s.step
+ if start < 0 or (stop is not None and stop < 0) or step <= 0:
+ raise ValueError
+ indices = count() if stop is None else range(max(stop, start))
+ next_i = start
+ for i, element in zip(indices, iterable):
+ if i == next_i:
+ yield element
+ next_i += step
.. function:: pairwise(iterable)
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]
