https://github.com/python/cpython/commit/44f67916dafd3583f482e6d001766581a1a734fc
commit: 44f67916dafd3583f482e6d001766581a1a734fc
branch: main
author: Nikita Sobolev <[email protected]>
committer: sobolevn <[email protected]>
date: 2024-05-05T21:46:37+03:00
summary:
gh-117389: Fix `test_compileall.EncodingTest` (#117390)
files:
M Lib/test/test_compileall.py
diff --git a/Lib/test/test_compileall.py b/Lib/test/test_compileall.py
index 14c2af19e3eb28..bf0fd051672db4 100644
--- a/Lib/test/test_compileall.py
+++ b/Lib/test/test_compileall.py
@@ -502,19 +502,25 @@ def setUp(self):
self.directory = tempfile.mkdtemp()
self.source_path = os.path.join(self.directory, '_test.py')
with open(self.source_path, 'w', encoding='utf-8') as file:
- file.write('# -*- coding: utf-8 -*-\n')
- file.write('print u"\u20ac"\n')
+ # Intentional syntax error: bytes can only contain
+ # ASCII literal characters.
+ file.write('b"\u20ac"')
def tearDown(self):
shutil.rmtree(self.directory)
def test_error(self):
- try:
- orig_stdout = sys.stdout
- sys.stdout = io.TextIOWrapper(io.BytesIO(),encoding='ascii')
- compileall.compile_dir(self.directory)
- finally:
- sys.stdout = orig_stdout
+ buffer = io.TextIOWrapper(io.BytesIO(), encoding='ascii')
+ with contextlib.redirect_stdout(buffer):
+ compiled = compileall.compile_dir(self.directory)
+ self.assertFalse(compiled) # should not be successful
+ buffer.seek(0)
+ res = buffer.read()
+ self.assertIn(
+ 'SyntaxError: bytes can only contain ASCII literal characters',
+ res,
+ )
+ self.assertNotIn('UnicodeEncodeError', res)
class CommandLineTestsBase:
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]
