https://github.com/python/cpython/commit/4702b7b5bdc07d046576b4126cf4e4f5f7145abb
commit: 4702b7b5bdc07d046576b4126cf4e4f5f7145abb
branch: main
author: Brandt Bucher <[email protected]>
committer: brandtbucher <[email protected]>
date: 2024-05-16T12:11:42-04:00
summary:
GH-118943: Fix a race condition when generating jit_stencils.h (GH-118957)
files:
A Misc/NEWS.d/next/Build/2024-05-11-15-11-30.gh-issue-118943.VI_MnY.rst
M Tools/jit/_targets.py
diff --git
a/Misc/NEWS.d/next/Build/2024-05-11-15-11-30.gh-issue-118943.VI_MnY.rst
b/Misc/NEWS.d/next/Build/2024-05-11-15-11-30.gh-issue-118943.VI_MnY.rst
new file mode 100644
index 00000000000000..4e886be034fb82
--- /dev/null
+++ b/Misc/NEWS.d/next/Build/2024-05-11-15-11-30.gh-issue-118943.VI_MnY.rst
@@ -0,0 +1,3 @@
+Fix a possible race condition affecting parallel builds configured with
+``--enable-experimental-jit``, in which compilation errors could be caused
+by an incompletely-generated header file.
diff --git a/Tools/jit/_targets.py b/Tools/jit/_targets.py
index b020f49cf4a2c1..5604c429bcf8ad 100644
--- a/Tools/jit/_targets.py
+++ b/Tools/jit/_targets.py
@@ -212,13 +212,18 @@ def build(
):
return
stencil_groups = asyncio.run(self._build_stencils())
- with jit_stencils.open("w") as file:
- file.write(digest)
- if comment:
- file.write(f"// {comment}\n\n")
- file.write("")
- for line in _writer.dump(stencil_groups):
- file.write(f"{line}\n")
+ jit_stencils_new = out / "jit_stencils.h.new"
+ try:
+ with jit_stencils_new.open("w") as file:
+ file.write(digest)
+ if comment:
+ file.write(f"// {comment}\n")
+ file.write("\n")
+ for line in _writer.dump(stencil_groups):
+ file.write(f"{line}\n")
+ jit_stencils_new.replace(jit_stencils)
+ finally:
+ jit_stencils_new.unlink(missing_ok=True)
class _COFF(
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]
