[Python-checkins] [3.8] gh-119690: Fixes buffer type confusion in _winapi.CreateFile and _winapi.CreateNamedPipe audit events (GH-119735) (#123680)

[ambv]

https://github.com/python/cpython/commit/2309739fd8bbe1b20442a6f59d7e42ed26a7875c
commit: 2309739fd8bbe1b20442a6f59d7e42ed26a7875c
branch: 3.8
author: Miss Islington (bot) <31488909+miss-isling...@users.noreply.github.com>
committer: ambv <luk...@langa.pl>
date: 2024-09-04T18:22:24+02:00
summary:

[3.8] gh-119690: Fixes buffer type confusion in _winapi.CreateFile and 
_winapi.CreateNamedPipe audit events (GH-119735) (#123680)

(cherry picked from commit 2e861ac1cd4359463f6a13efd3d3578fce71e5ab)

Co-authored-by: Steve Dower <steve.do...@python.org>

files:
A Misc/NEWS.d/next/Windows/2024-05-29-17-05-28.gh-issue-119690.U6RMtm.rst
M Modules/_winapi.c

diff --git 
a/Misc/NEWS.d/next/Windows/2024-05-29-17-05-28.gh-issue-119690.U6RMtm.rst 
b/Misc/NEWS.d/next/Windows/2024-05-29-17-05-28.gh-issue-119690.U6RMtm.rst
new file mode 100644
index 00000000000000..44889794d9a465
--- /dev/null
+++ b/Misc/NEWS.d/next/Windows/2024-05-29-17-05-28.gh-issue-119690.U6RMtm.rst
@@ -0,0 +1,2 @@
+Fixes data type confusion in audit events raised by ``_winapi.CreateFile``
+and ``_winapi.CreateNamedPipe``.
diff --git a/Modules/_winapi.c b/Modules/_winapi.c
index 647075cdb1788c..c524fd9850dae3 100644
--- a/Modules/_winapi.c
+++ b/Modules/_winapi.c
@@ -461,7 +461,7 @@ _winapi_CreateFile_impl(PyObject *module, LPCTSTR file_name,
 {
     HANDLE handle;
 
-    if (PySys_Audit("_winapi.CreateFile", "uIIII",
+    if (PySys_Audit("_winapi.CreateFile", "sIIII",
                     file_name, desired_access, share_mode,
                     creation_disposition, flags_and_attributes) < 0) {
         return INVALID_HANDLE_VALUE;
@@ -682,7 +682,7 @@ _winapi_CreateNamedPipe_impl(PyObject *module, LPCTSTR 
name, DWORD open_mode,
 {
     HANDLE handle;
 
-    if (PySys_Audit("_winapi.CreateNamedPipe", "uII",
+    if (PySys_Audit("_winapi.CreateNamedPipe", "sII",
                     name, open_mode, pipe_mode) < 0) {
         return INVALID_HANDLE_VALUE;
     }

_______________________________________________
Python-checkins mailing list -- python-checkins@python.org
To unsubscribe send an email to python-checkins-le...@python.org
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: arch...@mail-archive.com