https://github.com/python/cpython/commit/c203955f3b433e06118d00a2fe7215546a0b7fe6
commit: c203955f3b433e06118d00a2fe7215546a0b7fe6
branch: main
author: Victor Stinner <[email protected]>
committer: vstinner <[email protected]>
date: 2024-10-08T16:25:24+02:00
summary:
gh-124502: Optimize unicode_eq() (#125105)
files:
M Objects/stringlib/eq.h
diff --git a/Objects/stringlib/eq.h b/Objects/stringlib/eq.h
index 2eac4baf5ca9ce..821b692f26b830 100644
--- a/Objects/stringlib/eq.h
+++ b/Objects/stringlib/eq.h
@@ -4,14 +4,19 @@
* unicode_eq() is called when the hash of two unicode objects is equal.
*/
Py_LOCAL_INLINE(int)
-unicode_eq(PyObject *a, PyObject *b)
+unicode_eq(PyObject *str1, PyObject *str2)
{
- if (PyUnicode_GET_LENGTH(a) != PyUnicode_GET_LENGTH(b))
+ Py_ssize_t len = PyUnicode_GET_LENGTH(str1);
+ if (PyUnicode_GET_LENGTH(str2) != len) {
return 0;
- if (PyUnicode_GET_LENGTH(a) == 0)
- return 1;
- if (PyUnicode_KIND(a) != PyUnicode_KIND(b))
+ }
+
+ int kind = PyUnicode_KIND(str1);
+ if (PyUnicode_KIND(str2) != kind) {
return 0;
- return memcmp(PyUnicode_1BYTE_DATA(a), PyUnicode_1BYTE_DATA(b),
- PyUnicode_GET_LENGTH(a) * PyUnicode_KIND(a)) == 0;
+ }
+
+ const void *data1 = PyUnicode_DATA(str1);
+ const void *data2 = PyUnicode_DATA(str2);
+ return (memcmp(data1, data2, len * kind) == 0);
}
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]
