https://github.com/python/cpython/commit/79805d228440814c0674ab5190ef17f235503d2e
commit: 79805d228440814c0674ab5190ef17f235503d2e
branch: main
author: Serhiy Storchaka <storch...@gmail.com>
committer: serhiy-storchaka <storch...@gmail.com>
date: 2024-11-11T18:28:30+02:00
summary:
gh-117941: Reject option names starting with "--no-" in
argparse.BooleanOptionalAction (GH-125894)
They never worked correctly.
files:
A Misc/NEWS.d/next/Library/2024-10-23-20-44-30.gh-issue-117941.Y9jdlW.rst
M Lib/argparse.py
M Lib/test/test_argparse.py
diff --git a/Lib/argparse.py b/Lib/argparse.py
index 072cd5e7dc0d06..5ecfdca17175e3 100644
--- a/Lib/argparse.py
+++ b/Lib/argparse.py
@@ -863,6 +863,9 @@ def __init__(self,
_option_strings.append(option_string)
if option_string.startswith('--'):
+ if option_string.startswith('--no-'):
+ raise ValueError(f'invalid option name {option_string!r} '
+ f'for BooleanOptionalAction')
option_string = '--no-' + option_string[2:]
_option_strings.append(option_string)
diff --git a/Lib/test/test_argparse.py b/Lib/test/test_argparse.py
index ba9876570385d3..cbf119ed2dabbb 100644
--- a/Lib/test/test_argparse.py
+++ b/Lib/test/test_argparse.py
@@ -789,6 +789,13 @@ def test_const(self):
self.assertIn("got an unexpected keyword argument 'const'",
str(cm.exception))
+ def test_invalid_name(self):
+ parser = argparse.ArgumentParser()
+ with self.assertRaises(ValueError) as cm:
+ parser.add_argument('--no-foo',
action=argparse.BooleanOptionalAction)
+ self.assertEqual(str(cm.exception),
+ "invalid option name '--no-foo' for
BooleanOptionalAction")
+
class TestBooleanOptionalActionRequired(ParserTestCase):
"""Tests BooleanOptionalAction required"""
diff --git
a/Misc/NEWS.d/next/Library/2024-10-23-20-44-30.gh-issue-117941.Y9jdlW.rst
b/Misc/NEWS.d/next/Library/2024-10-23-20-44-30.gh-issue-117941.Y9jdlW.rst
new file mode 100644
index 00000000000000..9c2553f0f0e8cd
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2024-10-23-20-44-30.gh-issue-117941.Y9jdlW.rst
@@ -0,0 +1,2 @@
+:class:`!argparse.BooleanOptionalAction` now rejects option names starting
+with ``--no-``.
_______________________________________________
Python-checkins mailing list -- python-checkins@python.org
To unsubscribe send an email to python-checkins-le...@python.org
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: arch...@mail-archive.com
