https://github.com/python/cpython/commit/6985b4be9b01f3c6d581a93e58f5b14adb793d92
commit: 6985b4be9b01f3c6d581a93e58f5b14adb793d92
branch: 3.12
author: Miss Islington (bot) <[email protected]>
committer: Yhg1s <[email protected]>
date: 2025-02-04T00:24:56+01:00
summary:

[3.12] gh-129345: null check for indent syslogmodule (GH-129348) (#129443)

gh-129345: null check for indent syslogmodule (GH-129348)
(cherry picked from commit 25cf79a0829422bd8479ca0c13c72b769422077b)

Co-authored-by: Burkov Egor <[email protected]>

files:
A 
Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst
M Modules/syslogmodule.c

diff --git 
a/Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst
 
b/Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst
new file mode 100644
index 00000000000000..68e1103db45652
--- /dev/null
+++ 
b/Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst
@@ -0,0 +1 @@
+Fix null pointer dereference in :func:`syslog.openlog` when an audit hook 
raises an exception.
diff --git a/Modules/syslogmodule.c b/Modules/syslogmodule.c
index 722364e0751d9f..c925a42dc05c53 100644
--- a/Modules/syslogmodule.c
+++ b/Modules/syslogmodule.c
@@ -170,7 +170,7 @@ syslog_openlog_impl(PyObject *module, PyObject *ident, long 
logopt,
         }
     }
     if (PySys_Audit("syslog.openlog", "Oll", ident ? ident : Py_None, logopt, 
facility) < 0) {
-        Py_DECREF(ident);
+        Py_XDECREF(ident);
         return NULL;
     }
 

_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]

Reply via email to