https://github.com/python/cpython/commit/f6c24a5c89a1f08d583ab7f4d5c6751223f8e280
commit: f6c24a5c89a1f08d583ab7f4d5c6751223f8e280
branch: main
author: sobolevn <m...@sobolevn.me>
committer: sobolevn <m...@sobolevn.me>
date: 2025-03-14T10:16:50Z
summary:
gh-131219: Improve tests in `test_lzma.py` by adding more asserts (#131220)
files:
M Lib/test/test_lzma.py
diff --git a/Lib/test/test_lzma.py b/Lib/test/test_lzma.py
index 22478c14fb4a65..4dd10faf71360a 100644
--- a/Lib/test/test_lzma.py
+++ b/Lib/test/test_lzma.py
@@ -538,13 +538,17 @@ class FileTestCase(unittest.TestCase):
def test_init(self):
with LZMAFile(BytesIO(COMPRESSED_XZ)) as f:
- pass
+ self.assertIsInstance(f, LZMAFile)
+ self.assertEqual(f.mode, "rb")
with LZMAFile(BytesIO(), "w") as f:
- pass
+ self.assertIsInstance(f, LZMAFile)
+ self.assertEqual(f.mode, "wb")
with LZMAFile(BytesIO(), "x") as f:
- pass
+ self.assertIsInstance(f, LZMAFile)
+ self.assertEqual(f.mode, "wb")
with LZMAFile(BytesIO(), "a") as f:
- pass
+ self.assertIsInstance(f, LZMAFile)
+ self.assertEqual(f.mode, "wb")
def test_init_with_PathLike_filename(self):
filename = FakePath(TESTFN)
@@ -573,26 +577,32 @@ def test_init_with_filename(self):
def test_init_mode(self):
with TempFile(TESTFN):
- with LZMAFile(TESTFN, "r"):
- pass
- with LZMAFile(TESTFN, "rb"):
- pass
- with LZMAFile(TESTFN, "w"):
- pass
- with LZMAFile(TESTFN, "wb"):
- pass
- with LZMAFile(TESTFN, "a"):
- pass
- with LZMAFile(TESTFN, "ab"):
- pass
+ with LZMAFile(TESTFN, "r") as f:
+ self.assertIsInstance(f, LZMAFile)
+ self.assertEqual(f.mode, "rb")
+ with LZMAFile(TESTFN, "rb") as f:
+ self.assertIsInstance(f, LZMAFile)
+ self.assertEqual(f.mode, "rb")
+ with LZMAFile(TESTFN, "w") as f:
+ self.assertIsInstance(f, LZMAFile)
+ self.assertEqual(f.mode, "wb")
+ with LZMAFile(TESTFN, "wb") as f:
+ self.assertIsInstance(f, LZMAFile)
+ self.assertEqual(f.mode, "wb")
+ with LZMAFile(TESTFN, "a") as f:
+ self.assertIsInstance(f, LZMAFile)
+ self.assertEqual(f.mode, "wb")
+ with LZMAFile(TESTFN, "ab") as f:
+ self.assertIsInstance(f, LZMAFile)
+ self.assertEqual(f.mode, "wb")
def test_init_with_x_mode(self):
self.addCleanup(unlink, TESTFN)
for mode in ("x", "xb"):
unlink(TESTFN)
with LZMAFile(TESTFN, mode) as f:
- pass
- self.assertEqual(f.mode, 'wb')
+ self.assertIsInstance(f, LZMAFile)
+ self.assertEqual(f.mode, 'wb')
with self.assertRaises(FileExistsError):
LZMAFile(TESTFN, mode)
_______________________________________________
Python-checkins mailing list -- python-checkins@python.org
To unsubscribe send an email to python-checkins-le...@python.org
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: arch...@mail-archive.com
