https://github.com/python/cpython/commit/6afab81f72cae75baee877271a7a75c4ad187f84 commit: 6afab81f72cae75baee877271a7a75c4ad187f84 branch: 3.13 author: Miss Islington (bot) <31488909+miss-isling...@users.noreply.github.com> committer: sobolevn <m...@sobolevn.me> date: 2025-04-07T12:23:02Z summary:
[3.13] gh-132171: Fix `_interpreters.run_string` crash on string subclass (GH-132173) (#132219) gh-132171: Fix `_interpreters.run_string` crash on string subclass (GH-132173) (cherry picked from commit 398071871066548954f4c51e8250d13b7c9659e0) Co-authored-by: sobolevn <m...@sobolevn.me> files: A Misc/NEWS.d/next/Library/2025-04-06-23-09-21.gh-issue-132171.zZqvfn.rst M Lib/test/test__interpreters.py M Modules/_interpretersmodule.c diff --git a/Lib/test/test__interpreters.py b/Lib/test/test__interpreters.py index 8f32a446572d5a..3de774ae8b012e 100644 --- a/Lib/test/test__interpreters.py +++ b/Lib/test/test__interpreters.py @@ -745,6 +745,12 @@ def test_bytes_for_script(self): with self.assertRaises(TypeError): _interpreters.run_string(self.id, b'print("spam")') + def test_str_subclass_string(self): + class StrSubclass(str): pass + + output = _run_output(self.id, StrSubclass('print(1 + 2)')) + self.assertEqual(output, '3\n') + def test_with_shared(self): r, w = os.pipe() diff --git a/Misc/NEWS.d/next/Library/2025-04-06-23-09-21.gh-issue-132171.zZqvfn.rst b/Misc/NEWS.d/next/Library/2025-04-06-23-09-21.gh-issue-132171.zZqvfn.rst new file mode 100644 index 00000000000000..89f34fa3168cae --- /dev/null +++ b/Misc/NEWS.d/next/Library/2025-04-06-23-09-21.gh-issue-132171.zZqvfn.rst @@ -0,0 +1 @@ +Fix crash of ``_interpreters.run_string`` on string subclasses. diff --git a/Modules/_interpretersmodule.c b/Modules/_interpretersmodule.c index c968b33939c420..8f912d803ba519 100644 --- a/Modules/_interpretersmodule.c +++ b/Modules/_interpretersmodule.c @@ -331,7 +331,7 @@ get_code_str(PyObject *arg, Py_ssize_t *len_p, PyObject **bytes_p, int *flags_p) int flags = 0; if (PyUnicode_Check(arg)) { - assert(PyUnicode_CheckExact(arg) + assert(PyUnicode_Check(arg) && (check_code_str((PyUnicodeObject *)arg) == NULL)); codestr = PyUnicode_AsUTF8AndSize(arg, &len); if (codestr == NULL) { _______________________________________________ Python-checkins mailing list -- python-checkins@python.org To unsubscribe send an email to python-checkins-le...@python.org https://mail.python.org/mailman3/lists/python-checkins.python.org/ Member address: arch...@mail-archive.com