https://github.com/python/cpython/commit/8b7cb947c5046d8fb32aad532048de87e09ed3f9
commit: 8b7cb947c5046d8fb32aad532048de87e09ed3f9
branch: main
author: Serhiy Storchaka <storch...@gmail.com>
committer: serhiy-storchaka <storch...@gmail.com>
date: 2025-04-16T13:05:54+03:00
summary:
gh-127591: Fix altering environment in test_urllib2 (unsetting no_proxy)
(GH-132584)
files:
M Lib/test/test_urllib2.py
diff --git a/Lib/test/test_urllib2.py b/Lib/test/test_urllib2.py
index b1229607c516c7..7d7f2fa00d35b6 100644
--- a/Lib/test/test_urllib2.py
+++ b/Lib/test/test_urllib2.py
@@ -1446,7 +1446,8 @@ def test_proxy(self):
[tup[0:2] for tup in o.calls])
def test_proxy_no_proxy(self):
- os.environ['no_proxy'] = 'python.org'
+ env = self.enterContext(os_helper.EnvironmentVarGuard())
+ env['no_proxy'] = 'python.org'
o = OpenerDirector()
ph = urllib.request.ProxyHandler(dict(http="proxy.example.com"))
o.add_handler(ph)
@@ -1458,10 +1459,10 @@ def test_proxy_no_proxy(self):
self.assertEqual(req.host, "www.python.org")
o.open(req)
self.assertEqual(req.host, "www.python.org")
- del os.environ['no_proxy']
def test_proxy_no_proxy_all(self):
- os.environ['no_proxy'] = '*'
+ env = self.enterContext(os_helper.EnvironmentVarGuard())
+ env['no_proxy'] = '*'
o = OpenerDirector()
ph = urllib.request.ProxyHandler(dict(http="proxy.example.com"))
o.add_handler(ph)
@@ -1469,7 +1470,6 @@ def test_proxy_no_proxy_all(self):
self.assertEqual(req.host, "www.python.org")
o.open(req)
self.assertEqual(req.host, "www.python.org")
- del os.environ['no_proxy']
def test_proxy_https(self):
o = OpenerDirector()
_______________________________________________
Python-checkins mailing list -- python-checkins@python.org
To unsubscribe send an email to python-checkins-le...@python.org
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: arch...@mail-archive.com
