[Python-checkins] gh-133562: Skip security descriptors on unsupported Windows API partitions (GH-133563)

[zooba]

https://github.com/python/cpython/commit/e528aef7e2952a11119cf95c9198ad183dc7af7f
commit: e528aef7e2952a11119cf95c9198ad183dc7af7f
branch: main
author: Max Bachmann <max.bachm...@iracing.com>
committer: zooba <steve.do...@microsoft.com>
date: 2025-05-14T11:34:41Z
summary:

gh-133562: Skip security descriptors on unsupported Windows API partitions 
(GH-133563)

files:
A Misc/NEWS.d/next/Windows/2025-05-07-09-02-19.gh-issue-133562.lqqNW1.rst
M Modules/posixmodule.c

diff --git 
a/Misc/NEWS.d/next/Windows/2025-05-07-09-02-19.gh-issue-133562.lqqNW1.rst 
b/Misc/NEWS.d/next/Windows/2025-05-07-09-02-19.gh-issue-133562.lqqNW1.rst
new file mode 100644
index 00000000000000..884425b839a264
--- /dev/null
+++ b/Misc/NEWS.d/next/Windows/2025-05-07-09-02-19.gh-issue-133562.lqqNW1.rst
@@ -0,0 +1 @@
+Disable handling of security descriptors by :func:`os.mkdir` with mode 
``0o700`` on WinAPI partitions that do not support it. This only affects custom 
builds for specialized targets.
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
index 9cc0533f0dcfd1..bb3bfe802b93e8 100644
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -5736,6 +5736,9 @@ os_mkdir_impl(PyObject *module, path_t *path, int mode, 
int dir_fd)
 
 #ifdef MS_WINDOWS
     Py_BEGIN_ALLOW_THREADS
+    // For API sets that don't support these APIs, we have no choice
+    // but to silently create a directory with default ACL.
+#if defined(MS_WINDOWS_APP) || defined(MS_WINDOWS_SYSTEM)
     if (mode == 0700 /* 0o700 */) {
         ULONG sdSize;
         pSecAttr = &secAttr;
@@ -5751,6 +5754,7 @@ os_mkdir_impl(PyObject *module, path_t *path, int mode, 
int dir_fd)
             error = GetLastError();
         }
     }
+#endif
     if (!error) {
         result = CreateDirectoryW(path->wide, pSecAttr);
         if (secAttr.lpSecurityDescriptor &&

_______________________________________________
Python-checkins mailing list -- python-checkins@python.org
To unsubscribe send an email to python-checkins-le...@python.org
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: arch...@mail-archive.com