https://github.com/python/cpython/commit/e3dda8f81832008adf19906004f0cd53de95dd0b
commit: e3dda8f81832008adf19906004f0cd53de95dd0b
branch: main
author: Gustaf <79180496+gg...@users.noreply.github.com>
committer: gpshead <g...@krypto.org>
date: 2025-05-19T17:54:48-07:00
summary:
gh-133940: test_strftime incorrectly calculates expected week (GH-134281)
Let the system determine the correct tm_wday and tm_isdst.
files:
M Lib/test/test_strftime.py
diff --git a/Lib/test/test_strftime.py b/Lib/test/test_strftime.py
index 752e31359cf206..375f6aaedd8934 100644
--- a/Lib/test/test_strftime.py
+++ b/Lib/test/test_strftime.py
@@ -39,7 +39,21 @@ def _update_variables(self, now):
if now[3] < 12: self.ampm='(AM|am)'
else: self.ampm='(PM|pm)'
- self.jan1 = time.localtime(time.mktime((now[0], 1, 1, 0, 0, 0, 0, 1,
0)))
+ jan1 = time.struct_time(
+ (
+ now.tm_year, # Year
+ 1, # Month (January)
+ 1, # Day (1st)
+ 0, # Hour (0)
+ 0, # Minute (0)
+ 0, # Second (0)
+ -1, # tm_wday (will be determined)
+ 1, # tm_yday (day 1 of the year)
+ -1, # tm_isdst (let the system determine)
+ )
+ )
+ # use mktime to get the correct tm_wday and tm_isdst values
+ self.jan1 = time.localtime(time.mktime(jan1))
try:
if now[8]: self.tz = time.tzname[1]
_______________________________________________
Python-checkins mailing list -- python-checkins@python.org
To unsubscribe send an email to python-checkins-le...@python.org
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: arch...@mail-archive.com
