https://github.com/python/cpython/commit/91e6a58e2d6fd23e886135457e28dfa980ec49ed
commit: 91e6a58e2d6fd23e886135457e28dfa980ec49ed
branch: main
author: Hood Chatham <roberthoodchat...@gmail.com>
committer: freakboy3742 <russ...@keith-magee.com>
date: 2025-05-20T18:41:14Z
summary:

gh-127146: xfail more Emscripten stack overflows (#134358)

Adds some additional test xfails for Emscripten stack overflows. Also corrects 
a test skip for test_io.

files:
M Lib/test/test_builtin.py
M Lib/test/test_capi/test_misc.py
M Lib/test/test_descr.py
M Lib/test/test_exceptions.py
M Lib/test/test_io.py

diff --git a/Lib/test/test_builtin.py b/Lib/test/test_builtin.py
index 31597a320d418a..f1f877c47a1e7a 100644
--- a/Lib/test/test_builtin.py
+++ b/Lib/test/test_builtin.py
@@ -1120,6 +1120,7 @@ def test_filter_pickle(self):
             self.check_iter_pickle(f1, list(f2), proto)
 
     @support.skip_wasi_stack_overflow()
+    @support.skip_emscripten_stack_overflow()
     @support.requires_resource('cpu')
     def test_filter_dealloc(self):
         # Tests recursive deallocation of nested filter objects using the
diff --git a/Lib/test/test_capi/test_misc.py b/Lib/test/test_capi/test_misc.py
index a597f23a992e7b..f74694a7a745a4 100644
--- a/Lib/test/test_capi/test_misc.py
+++ b/Lib/test/test_capi/test_misc.py
@@ -412,10 +412,12 @@ def test_trashcan_subclass(self):
             L = MyList((L,))
 
     @support.requires_resource('cpu')
+    @support.skip_emscripten_stack_overflow()
     def test_trashcan_python_class1(self):
         self.do_test_trashcan_python_class(list)
 
     @support.requires_resource('cpu')
+    @support.skip_emscripten_stack_overflow()
     def test_trashcan_python_class2(self):
         from _testcapi import MyList
         self.do_test_trashcan_python_class(MyList)
diff --git a/Lib/test/test_descr.py b/Lib/test/test_descr.py
index 76937432a43037..14026531e22333 100644
--- a/Lib/test/test_descr.py
+++ b/Lib/test/test_descr.py
@@ -4523,6 +4523,7 @@ class Oops(object):
         del o
 
     @support.skip_wasi_stack_overflow()
+    @support.skip_emscripten_stack_overflow()
     @support.requires_resource('cpu')
     def test_wrapper_segfault(self):
         # SF 927248: deeply nested wrappers could cause stack overflow
diff --git a/Lib/test/test_exceptions.py b/Lib/test/test_exceptions.py
index d177e3dc0f5007..cfd4a3e87695f5 100644
--- a/Lib/test/test_exceptions.py
+++ b/Lib/test/test_exceptions.py
@@ -1429,6 +1429,7 @@ def g():
         self.assertIn("maximum recursion depth exceeded", str(exc))
 
     @support.skip_wasi_stack_overflow()
+    @support.skip_emscripten_stack_overflow()
     @cpython_only
     @support.requires_resource('cpu')
     def test_trashcan_recursion(self):
diff --git a/Lib/test/test_io.py b/Lib/test/test_io.py
index 5a8f1949baaa98..90680c6d47ab41 100644
--- a/Lib/test/test_io.py
+++ b/Lib/test/test_io.py
@@ -572,7 +572,7 @@ def do_test(test, obj, abilities):
         for [test, abilities] in tests:
             with self.subTest(test):
                 if test == pipe_writer and not 
threading_helper.can_start_thread:
-                    skipTest()
+                    self.skipTest("Need threads")
                 with test() as obj:
                     do_test(test, obj, abilities)
 

_______________________________________________
Python-checkins mailing list -- python-checkins@python.org
To unsubscribe send an email to python-checkins-le...@python.org
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: arch...@mail-archive.com

Reply via email to