https://github.com/python/cpython/commit/e81c4e84b3a8688a367099e3adf9b2fcf914447f
commit: e81c4e84b3a8688a367099e3adf9b2fcf914447f
branch: main
author: Hood Chatham <[email protected]>
committer: freakboy3742 <[email protected]>
date: 2025-07-16T06:17:16+02:00
summary:
gh-127146: Report uid in Emscripten + node as native uid (#136509)
Corrects the handling of getuid on emscripten, which was consistently reporting
as 0.
files:
A Python/emscripten_syscalls.c
M Tools/c-analyzer/cpython/_parser.py
M configure
M configure.ac
diff --git a/Python/emscripten_syscalls.c b/Python/emscripten_syscalls.c
new file mode 100644
index 00000000000000..7875bfc8fe56ae
--- /dev/null
+++ b/Python/emscripten_syscalls.c
@@ -0,0 +1,19 @@
+#include "emscripten.h"
+
+// If we're running in node, report the UID of the user in the native system as
+// the UID of the user. Since the nodefs will report the uid correctly, if we
+// don't make getuid report it correctly too we'll see some permission errors.
+// Normally __syscall_getuid32 is a stub that always returns 0 but it is
+// defined with weak linkage so we can override it.
+EM_JS(int, __syscall_getuid32_js, (void), {
+ // If we're in node and we can, report the native uid
+ if (typeof process !== "undefined" && typeof process.getuid ===
"function") {
+ return process.getuid();
+ }
+ // Fall back to the stub case of returning 0.
+ return 0;
+})
+
+int __syscall_getuid32(void) {
+ return __syscall_getuid32_js();
+}
diff --git a/Tools/c-analyzer/cpython/_parser.py
b/Tools/c-analyzer/cpython/_parser.py
index 037fe11ea223c7..cfbf0d14348499 100644
--- a/Tools/c-analyzer/cpython/_parser.py
+++ b/Tools/c-analyzer/cpython/_parser.py
@@ -66,6 +66,7 @@ def clean_lines(text):
Python/dynload_dl.c # dl.h
Python/dynload_hpux.c # dl.h
Python/emscripten_signal.c
+Python/emscripten_syscalls.c
Python/thread_pthread.h
Python/thread_pthread_stubs.h
diff --git a/configure b/configure
index 71d831e4d8a6bb..3570eecdcef94f 100755
--- a/configure
+++ b/configure
@@ -19061,7 +19061,7 @@ PLATFORM_OBJS=
case $ac_sys_system in #(
Emscripten) :
- as_fn_append PLATFORM_OBJS ' Python/emscripten_signal.o
Python/emscripten_trampoline.o'
+ as_fn_append PLATFORM_OBJS ' Python/emscripten_signal.o
Python/emscripten_trampoline.o Python/emscripten_syscalls.o'
as_fn_append PLATFORM_HEADERS '
$(srcdir)/Include/internal/pycore_emscripten_signal.h
$(srcdir)/Include/internal/pycore_emscripten_trampoline.h'
;; #(
*) :
diff --git a/configure.ac b/configure.ac
index 91c26f34a524c1..3566c4b9038c2b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5121,7 +5121,7 @@ PLATFORM_OBJS=
AS_CASE([$ac_sys_system],
[Emscripten], [
- AS_VAR_APPEND([PLATFORM_OBJS], [' Python/emscripten_signal.o
Python/emscripten_trampoline.o'])
+ AS_VAR_APPEND([PLATFORM_OBJS], [' Python/emscripten_signal.o
Python/emscripten_trampoline.o Python/emscripten_syscalls.o'])
AS_VAR_APPEND([PLATFORM_HEADERS], ['
$(srcdir)/Include/internal/pycore_emscripten_signal.h
$(srcdir)/Include/internal/pycore_emscripten_trampoline.h'])
],
)
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3//lists/python-checkins.python.org
Member address: [email protected]
