https://github.com/python/cpython/commit/c730952aa64b790c75c437cb63a1242dc08c2e97
commit: c730952aa64b790c75c437cb63a1242dc08c2e97
branch: main
author: Hood Chatham <[email protected]>
committer: freakboy3742 <[email protected]>
date: 2025-07-16T14:02:25Z
summary:
gh-127146: Emscripten: more regular stack overflow skips (#136708)
Makes the Emscripten stack overflow skip message consistent with WASI,
and replaces some ad-hoc skips.
files:
M Lib/test/support/__init__.py
M Lib/test/test_descr.py
M Lib/test/test_xml_etree_c.py
diff --git a/Lib/test/support/__init__.py b/Lib/test/support/__init__.py
index fd39d3f7c95368..196a2e5c600e24 100644
--- a/Lib/test/support/__init__.py
+++ b/Lib/test/support/__init__.py
@@ -570,7 +570,7 @@ def skip_android_selinux(name):
is_wasi = sys.platform == "wasi"
def skip_emscripten_stack_overflow():
- return unittest.skipIf(is_emscripten, "Exhausts limited stack on
Emscripten")
+ return unittest.skipIf(is_emscripten, "Exhausts stack on Emscripten")
def skip_wasi_stack_overflow():
return unittest.skipIf(is_wasi, "Exhausts stack on WASI")
diff --git a/Lib/test/test_descr.py b/Lib/test/test_descr.py
index f6ec2cf5ce8b5c..8da6647c3f71fc 100644
--- a/Lib/test/test_descr.py
+++ b/Lib/test/test_descr.py
@@ -3942,7 +3942,7 @@ def __del__(self):
# it as a leak.
del C.__del__
- @unittest.skipIf(support.is_emscripten, "Seems to works in Pyodide?")
+ @support.skip_emscripten_stack_overflow()
@support.skip_wasi_stack_overflow()
def test_slots_trash(self):
# Testing slot trash...
diff --git a/Lib/test/test_xml_etree_c.py b/Lib/test/test_xml_etree_c.py
index 9ed0f4096a45e3..270b9d6da8e7b9 100644
--- a/Lib/test/test_xml_etree_c.py
+++ b/Lib/test/test_xml_etree_c.py
@@ -58,7 +58,7 @@ def test_del_attribute(self):
self.assertEqual(element.attrib, {'A': 'B', 'C': 'D'})
@support.skip_wasi_stack_overflow()
- @unittest.skipIf(support.is_emscripten, "segfaults")
+ @support.skip_emscripten_stack_overflow()
def test_trashcan(self):
# If this test fails, it will most likely die via segfault.
e = root = cET.Element('root')
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3//lists/python-checkins.python.org
Member address: [email protected]
