https://github.com/python/cpython/commit/aa4b5a77f36b9a68b880eddd32d8ae42c8a88314
commit: aa4b5a77f36b9a68b880eddd32d8ae42c8a88314
branch: main
author: Jiseok CHOI <[email protected]>
committer: corona10 <[email protected]>
date: 2025-10-24T20:20:09+09:00
summary:
gh-136535: Tests: Correct `Py_TPFLAGS_MANAGED_DICT` in `test_class.py`
(gh-136538)
files:
M Lib/test/test_class.py
diff --git a/Lib/test/test_class.py b/Lib/test/test_class.py
index 8c7a62a74ba90e..64222555166a2e 100644
--- a/Lib/test/test_class.py
+++ b/Lib/test/test_class.py
@@ -859,7 +859,12 @@ def __init__(self, arg):
from _testinternalcapi import has_inline_values
-Py_TPFLAGS_MANAGED_DICT = (1 << 2)
+Py_TPFLAGS_INLINE_VALUES = (1 << 2)
+Py_TPFLAGS_MANAGED_DICT = (1 << 4)
+
+class NoManagedDict:
+ __slots__ = ('a',)
+
class Plain:
pass
@@ -874,11 +879,31 @@ def __init__(self):
self.d = 4
+class VarSizedSubclass(tuple):
+ pass
+
+
class TestInlineValues(unittest.TestCase):
- def test_flags(self):
- self.assertEqual(Plain.__flags__ & Py_TPFLAGS_MANAGED_DICT,
Py_TPFLAGS_MANAGED_DICT)
- self.assertEqual(WithAttrs.__flags__ & Py_TPFLAGS_MANAGED_DICT,
Py_TPFLAGS_MANAGED_DICT)
+ def test_no_flags_for_slots_class(self):
+ flags = NoManagedDict.__flags__
+ self.assertEqual(flags & Py_TPFLAGS_MANAGED_DICT, 0)
+ self.assertEqual(flags & Py_TPFLAGS_INLINE_VALUES, 0)
+ self.assertFalse(has_inline_values(NoManagedDict()))
+
+ def test_both_flags_for_regular_class(self):
+ for cls in (Plain, WithAttrs):
+ with self.subTest(cls=cls.__name__):
+ flags = cls.__flags__
+ self.assertEqual(flags & Py_TPFLAGS_MANAGED_DICT,
Py_TPFLAGS_MANAGED_DICT)
+ self.assertEqual(flags & Py_TPFLAGS_INLINE_VALUES,
Py_TPFLAGS_INLINE_VALUES)
+ self.assertTrue(has_inline_values(cls()))
+
+ def test_managed_dict_only_for_varsized_subclass(self):
+ flags = VarSizedSubclass.__flags__
+ self.assertEqual(flags & Py_TPFLAGS_MANAGED_DICT,
Py_TPFLAGS_MANAGED_DICT)
+ self.assertEqual(flags & Py_TPFLAGS_INLINE_VALUES, 0)
+ self.assertFalse(has_inline_values(VarSizedSubclass()))
def test_has_inline_values(self):
c = Plain()
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3//lists/python-checkins.python.org
Member address: [email protected]
