https://github.com/python/cpython/commit/20b910ca8b6b1ad4593411999832f7e1c563acb9
commit: 20b910ca8b6b1ad4593411999832f7e1c563acb9
branch: 3.14
author: Miss Islington (bot) <[email protected]>
committer: gpshead <[email protected]>
date: 2025-11-29T07:25:46Z
summary:
[3.14] Fix multiprocessing queue test_get() (GH-142024) (#142070)
Fix multiprocessing queue test_get() (GH-142024)
* Replace sleep() with support.sleeping_retry().
* Test get_nowait() first.
* Restore previously disabled test.
Fix the failure:
FAIL: test_get
(test.test_multiprocessing_spawn.test_processes.WithProcessesTestQueue.test_get)
----------------------------------------------------------------------
Traceback (most recent call last):
File "Lib/test/_test_multiprocessing.py", line 1208, in test_get
self.assertEqual(queue_empty(queue), False)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: True != False
(cherry picked from commit 5e749d3743621be4c8bf5618ed3249e9fde9a599)
Co-authored-by: Victor Stinner <[email protected]>
files:
M Lib/test/_test_multiprocessing.py
diff --git a/Lib/test/_test_multiprocessing.py
b/Lib/test/_test_multiprocessing.py
index d5cd25a7980468..1a188daa003b85 100644
--- a/Lib/test/_test_multiprocessing.py
+++ b/Lib/test/_test_multiprocessing.py
@@ -1180,7 +1180,7 @@ def test_put(self):
@classmethod
def _test_get(cls, queue, child_can_start, parent_can_continue):
child_can_start.wait()
- #queue.put(1)
+ queue.put(1)
queue.put(2)
queue.put(3)
queue.put(4)
@@ -1204,15 +1204,16 @@ def test_get(self):
child_can_start.set()
parent_can_continue.wait()
- time.sleep(DELTA)
+ for _ in support.sleeping_retry(support.SHORT_TIMEOUT):
+ if not queue_empty(queue):
+ break
self.assertEqual(queue_empty(queue), False)
- # Hangs unexpectedly, remove for now
- #self.assertEqual(queue.get(), 1)
+ self.assertEqual(queue.get_nowait(), 1)
self.assertEqual(queue.get(True, None), 2)
self.assertEqual(queue.get(True), 3)
self.assertEqual(queue.get(timeout=1), 4)
- self.assertEqual(queue.get_nowait(), 5)
+ self.assertEqual(queue.get(), 5)
self.assertEqual(queue_empty(queue), True)
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3//lists/python-checkins.python.org
Member address: [email protected]
