https://github.com/python/cpython/commit/e1e4852133ea548479bc9b975420a32331df7cee
commit: e1e4852133ea548479bc9b975420a32331df7cee
branch: main
author: Victor Stinner <[email protected]>
committer: vstinner <[email protected]>
date: 2026-03-18T18:27:52+01:00
summary:
gh-146092: Handle _PyFrame_GetFrameObject() failures properly (#146124)
* Fix _PyFrame_GetLocals() and _PyFrame_GetLocals() error handling.
* _PyEval_ExceptionGroupMatch() now fails on _PyFrame_GetLocals()
error.
files:
M Objects/frameobject.c
M Python/ceval.c
diff --git a/Objects/frameobject.c b/Objects/frameobject.c
index 9a7abfc0ec26ab..8911de6f2bfc5b 100644
--- a/Objects/frameobject.c
+++ b/Objects/frameobject.c
@@ -2296,6 +2296,9 @@ _PyFrame_GetLocals(_PyInterpreterFrame *frame)
}
PyFrameObject* f = _PyFrame_GetFrameObject(frame);
+ if (f == NULL) {
+ return NULL;
+ }
return _PyFrameLocalsProxy_New(f);
}
diff --git a/Python/ceval.c b/Python/ceval.c
index 29f81317722a80..8a6895834cbb7e 100644
--- a/Python/ceval.c
+++ b/Python/ceval.c
@@ -2237,15 +2237,19 @@ _PyEval_ExceptionGroupMatch(_PyInterpreterFrame *frame,
PyObject* exc_value,
return -1;
}
PyFrameObject *f = _PyFrame_GetFrameObject(frame);
- if (f != NULL) {
- PyObject *tb = _PyTraceBack_FromFrame(NULL, f);
- if (tb == NULL) {
- Py_DECREF(wrapped);
- return -1;
- }
- PyException_SetTraceback(wrapped, tb);
- Py_DECREF(tb);
+ if (f == NULL) {
+ Py_DECREF(wrapped);
+ return -1;
+ }
+
+ PyObject *tb = _PyTraceBack_FromFrame(NULL, f);
+ if (tb == NULL) {
+ Py_DECREF(wrapped);
+ return -1;
}
+ PyException_SetTraceback(wrapped, tb);
+ Py_DECREF(tb);
+
*match = wrapped;
}
*rest = Py_NewRef(Py_None);
@@ -2620,6 +2624,11 @@ PyEval_GetLocals(void)
if (PyFrameLocalsProxy_Check(locals)) {
PyFrameObject *f = _PyFrame_GetFrameObject(current_frame);
+ if (f == NULL) {
+ Py_DECREF(locals);
+ return NULL;
+ }
+
PyObject *ret = f->f_locals_cache;
if (ret == NULL) {
ret = PyDict_New();
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3//lists/python-checkins.python.org
Member address: [email protected]
