https://github.com/python/cpython/commit/9f225e2c3448e8536e8e3f0d80dca45415f04ef0
commit: 9f225e2c3448e8536e8e3f0d80dca45415f04ef0
branch: main
author: Victor Stinner <[email protected]>
committer: vstinner <[email protected]>
date: 2026-06-05T15:24:46Z
summary:
gh-150436: Check returncode in Win32ProcessTestCase (#150972)
files:
M Lib/test/test_subprocess.py
diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py
index f944084aaa6d6a..d41cb1294a3daf 100644
--- a/Lib/test/test_subprocess.py
+++ b/Lib/test/test_subprocess.py
@@ -3719,8 +3719,9 @@ def test_startupinfo(self):
# Since Python is a console process, it won't be affected
# by wShowWindow, but the argument should be silently
# ignored
- subprocess.call(ZERO_RETURN_CMD,
- startupinfo=startupinfo)
+ rc = subprocess.call(ZERO_RETURN_CMD,
+ startupinfo=startupinfo)
+ self.assertEqual(rc, 0)
def test_startupinfo_keywords(self):
# startupinfo argument
@@ -3735,8 +3736,9 @@ def test_startupinfo_keywords(self):
# Since Python is a console process, it won't be affected
# by wShowWindow, but the argument should be silently
# ignored
- subprocess.call(ZERO_RETURN_CMD,
- startupinfo=startupinfo)
+ rc = subprocess.call(ZERO_RETURN_CMD,
+ startupinfo=startupinfo)
+ self.assertEqual(rc, 0)
def test_startupinfo_copy(self):
# bpo-34044: Popen must not modify input STARTUPINFO structure
@@ -3853,14 +3855,16 @@ def test_close_fds_with_stdio(self):
def test_empty_attribute_list(self):
startupinfo = subprocess.STARTUPINFO()
startupinfo.lpAttributeList = {}
- subprocess.call(ZERO_RETURN_CMD,
- startupinfo=startupinfo)
+ rc = subprocess.call(ZERO_RETURN_CMD,
+ startupinfo=startupinfo)
+ self.assertEqual(rc, 0)
def test_empty_handle_list(self):
startupinfo = subprocess.STARTUPINFO()
startupinfo.lpAttributeList = {"handle_list": []}
- subprocess.call(ZERO_RETURN_CMD,
- startupinfo=startupinfo)
+ rc = subprocess.call(ZERO_RETURN_CMD,
+ startupinfo=startupinfo)
+ self.assertEqual(rc, 0)
def test_shell_sequence(self):
# Run command through the shell (sequence)
@@ -3871,6 +3875,8 @@ def test_shell_sequence(self):
env=newenv)
with p:
self.assertIn(b"physalis", p.stdout.read())
+ p.communicate()
+ self.assertEqual(p.returncode, 0)
def test_shell_string(self):
# Run command through the shell (string)
@@ -3881,6 +3887,8 @@ def test_shell_string(self):
env=newenv)
with p:
self.assertIn(b"physalis", p.stdout.read())
+ p.communicate()
+ self.assertEqual(p.returncode, 0)
def test_shell_encodings(self):
# Run command through the shell (string)
@@ -3893,6 +3901,8 @@ def test_shell_encodings(self):
encoding=enc)
with p:
self.assertIn("physalis", p.stdout.read(), enc)
+ p.communicate()
+ self.assertEqual(p.returncode, 0)
def test_call_string(self):
# call() function with string argument on Windows
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3//lists/python-checkins.python.org
Member address: [email protected]
