https://github.com/python/cpython/commit/0f7dc2fefa9e1b1197519361af9df9cd4eff875f
commit: 0f7dc2fefa9e1b1197519361af9df9cd4eff875f
branch: main
author: Pieter Eendebak <[email protected]>
committer: corona10 <[email protected]>
date: 2026-06-07T21:06:36+09:00
summary:
gh-150942: Speed up re.findall and re.sub/subn result building (gh-150943)
files:
A Misc/NEWS.d/next/Library/2026-05-31-12-00-00.gh-issue-150942.Re7Ref.rst
M Modules/_sre/sre.c
diff --git
a/Misc/NEWS.d/next/Library/2026-05-31-12-00-00.gh-issue-150942.Re7Ref.rst
b/Misc/NEWS.d/next/Library/2026-05-31-12-00-00.gh-issue-150942.Re7Ref.rst
new file mode 100644
index 000000000000000..63967108b1e0b3b
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2026-05-31-12-00-00.gh-issue-150942.Re7Ref.rst
@@ -0,0 +1,3 @@
+Speed up :func:`re.findall`, :func:`re.sub` and :func:`re.subn` by appending
+result items to the output list without an extra reference-count round-trip
+(using the internal reference-stealing list append helper).
diff --git a/Modules/_sre/sre.c b/Modules/_sre/sre.c
index ee6cb4a371ea505..32aa06bed4a409c 100644
--- a/Modules/_sre/sre.c
+++ b/Modules/_sre/sre.c
@@ -42,6 +42,7 @@ static const char copyright[] =
#include "pycore_critical_section.h" // Py_BEGIN_CRITICAL_SECTION
#include "pycore_dict.h" // _PyDict_Next()
#include "pycore_long.h" // _PyLong_GetZero()
+#include "pycore_list.h" // _PyList_AppendTakeRef()
#include "pycore_moduleobject.h" // _PyModule_GetState()
#include "pycore_tuple.h" // _PyTuple_FromPairSteal
#include "pycore_unicodeobject.h" // _PyUnicode_Copy
@@ -986,8 +987,7 @@ _sre_SRE_Pattern_findall_impl(PatternObject *self, PyObject
*string,
break;
}
- status = PyList_Append(list, item);
- Py_DECREF(item);
+ status = _PyList_AppendTakeRef((PyListObject *)list, item);
if (status < 0)
goto error;
@@ -1333,8 +1333,7 @@ pattern_subx(_sremodulestate* module_state,
string, i, b);
if (!item)
goto error;
- status = PyList_Append(list, item);
- Py_DECREF(item);
+ status = _PyList_AppendTakeRef((PyListObject *)list, item);
if (status < 0)
goto error;
@@ -1363,8 +1362,7 @@ pattern_subx(_sremodulestate* module_state,
/* add to list */
if (item != Py_None) {
- status = PyList_Append(list, item);
- Py_DECREF(item);
+ status = _PyList_AppendTakeRef((PyListObject *)list, item);
if (status < 0)
goto error;
}
@@ -1381,8 +1379,7 @@ pattern_subx(_sremodulestate* module_state,
string, i, state.endpos);
if (!item)
goto error;
- status = PyList_Append(list, item);
- Py_DECREF(item);
+ status = _PyList_AppendTakeRef((PyListObject *)list, item);
if (status < 0)
goto error;
}
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3//lists/python-checkins.python.org
Member address: [email protected]
