https://github.com/python/cpython/commit/d87d77287392b78d36a06660228f6a5ca88888d7
commit: d87d77287392b78d36a06660228f6a5ca88888d7
branch: main
author: Victor Stinner <[email protected]>
committer: vstinner <[email protected]>
date: 2026-06-11T10:55:09Z
summary:
gh-151284: Fix test_capi on UBSan (#151286)
Comment two checks relying on undefined behavior in
test_fromwidechar() of test_capi.
Enable test_capi in GitHub Action "Reusable Sanitizer".
files:
M .github/workflows/reusable-san.yml
M Lib/test/test_capi/test_unicode.py
diff --git a/.github/workflows/reusable-san.yml
b/.github/workflows/reusable-san.yml
index 6127c7e1c053690..2ceb1000e8a5a9c 100644
--- a/.github/workflows/reusable-san.yml
+++ b/.github/workflows/reusable-san.yml
@@ -82,13 +82,10 @@ jobs:
run: make -j4
- name: Display build info
run: make pythoninfo
- # test_capi is skipped under UBSan because
- # they raise signals that UBSan with halt_on_error=1 intercepts.
- name: Tests
run: >-
./python -m test
${{ inputs.sanitizer == 'TSan' && '--tsan' || '' }}
- ${{ inputs.sanitizer == 'UBSan' && '-x test_capi' || '' }}
-j4 -W
- name: Parallel tests
if: >-
diff --git a/Lib/test/test_capi/test_unicode.py
b/Lib/test/test_capi/test_unicode.py
index 5dee25756fe2893..0dcd8a25ad0128d 100644
--- a/Lib/test/test_capi/test_unicode.py
+++ b/Lib/test/test_capi/test_unicode.py
@@ -842,9 +842,7 @@ def test_fromwidechar(self):
if SIZEOF_WCHAR_T == 2:
self.assertEqual(fromwidechar('a\U0001f600'.encode(encoding), 2),
'a\ud83d')
- self.assertRaises(MemoryError, fromwidechar, b'', PY_SSIZE_T_MAX)
self.assertRaises(SystemError, fromwidechar, b'\0'*SIZEOF_WCHAR_T, -2)
- self.assertRaises(SystemError, fromwidechar, b'\0'*SIZEOF_WCHAR_T,
PY_SSIZE_T_MIN)
self.assertEqual(fromwidechar(NULL, 0), '')
self.assertRaises(SystemError, fromwidechar, NULL, 1)
self.assertRaises(SystemError, fromwidechar, NULL, PY_SSIZE_T_MAX)
@@ -852,6 +850,10 @@ def test_fromwidechar(self):
self.assertRaises(SystemError, fromwidechar, NULL, -2)
self.assertRaises(SystemError, fromwidechar, NULL, PY_SSIZE_T_MIN)
+ # The following tests are skipped since they rely on undefined behavior
+ #self.assertRaises(MemoryError, fromwidechar, b'', PY_SSIZE_T_MAX)
+ #self.assertRaises(SystemError, fromwidechar, b'\0'*SIZEOF_WCHAR_T,
PY_SSIZE_T_MIN)
+
@support.cpython_only
@unittest.skipIf(_testlimitedcapi is None, 'need _testlimitedcapi module')
def test_aswidechar(self):
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3//lists/python-checkins.python.org
Member address: [email protected]
