https://github.com/python/cpython/commit/ad09d0050c88d91d4f5f0a70b8b42d54e9aeaefb commit: ad09d0050c88d91d4f5f0a70b8b42d54e9aeaefb branch: 3.15 author: Miss Islington (bot) <[email protected]> committer: hugovk <[email protected]> date: 2026-08-12T15:34:24+03:00 summary:
[3.15] gh-154568: Fix array unpickling of little-endian float16 (GH-154569) (#155557) Co-authored-by: PhysicistJohn <[email protected]> files: A Misc/NEWS.d/next/Library/2026-07-23-21-00-00.gh-issue-154568.float16-reconstructor.rst M Lib/test/test_array.py M Modules/arraymodule.c diff --git a/Lib/test/test_array.py b/Lib/test/test_array.py index 42213120fb6ced4..430f55f2129884b 100755 --- a/Lib/test/test_array.py +++ b/Lib/test/test_array.py @@ -224,6 +224,10 @@ def test_numbers(self): [-1<<63, (1<<63)-1, 0]), (['l'], SIGNED_INT64_BE, '>qqq', [-1<<63, (1<<63)-1, 0]), + (['e'], IEEE_754_FLOAT16_LE, '<eeee', + [1.0, float('inf'), float('-inf'), -0.0]), + (['e'], IEEE_754_FLOAT16_BE, '>eeee', + [1.0, float('inf'), float('-inf'), -0.0]), (['f'], IEEE_754_FLOAT_LE, '<ffff', [16711938.0, float('inf'), float('-inf'), -0.0]), (['f'], IEEE_754_FLOAT_BE, '>ffff', @@ -254,6 +258,16 @@ def test_numbers(self): self.assertEqual(a, b, msg="{0!r} != {1!r}; testcase={2!r}".format(a, b, testcase)) + def test_float16_endianness(self): + # gh-154568: array_reconstructor() slow-path decoder for + # IEEE_754_FLOAT16_LE ignored the encoding. + le_bytes = struct.pack('<e', 1.5) + be_bytes = struct.pack('>e', 1.5) + b_le = array_reconstructor(array.array, 'd', IEEE_754_FLOAT16_LE, le_bytes) + b_be = array_reconstructor(array.array, 'd', IEEE_754_FLOAT16_BE, be_bytes) + self.assertEqual(b_le.tolist(), [1.5]) + self.assertEqual(b_be.tolist(), [1.5]) + def test_unicode(self): teststr = "Bonne Journ\xe9e \U0002030a\U00020347" testcases = ( diff --git a/Misc/NEWS.d/next/Library/2026-07-23-21-00-00.gh-issue-154568.float16-reconstructor.rst b/Misc/NEWS.d/next/Library/2026-07-23-21-00-00.gh-issue-154568.float16-reconstructor.rst new file mode 100644 index 000000000000000..85c0c81231b6aea --- /dev/null +++ b/Misc/NEWS.d/next/Library/2026-07-23-21-00-00.gh-issue-154568.float16-reconstructor.rst @@ -0,0 +1 @@ +Fix :mod:`array` unpickling of little-endian float16. diff --git a/Modules/arraymodule.c b/Modules/arraymodule.c index 46aec5f201c849b..45cdf351cbb6ce8 100644 --- a/Modules/arraymodule.c +++ b/Modules/arraymodule.c @@ -2356,7 +2356,7 @@ array__array_reconstructor_impl(PyObject *module, PyTypeObject *arraytype, case IEEE_754_FLOAT16_LE: case IEEE_754_FLOAT16_BE: { Py_ssize_t i; - int le = (mformat_code == IEEE_754_FLOAT_LE) ? 1 : 0; + int le = (mformat_code == IEEE_754_FLOAT16_LE) ? 1 : 0; Py_ssize_t itemcount = Py_SIZE(items) / 2; const char *memstr = PyBytes_AS_STRING(items); _______________________________________________ Python-checkins mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3//lists/python-checkins.python.org Member address: [email protected]
