https://github.com/python/cpython/commit/2649b3760ce17a7c69fee9b5b273ef37bbb7e2e6
commit: 2649b3760ce17a7c69fee9b5b273ef37bbb7e2e6
branch: 3.14
author: Miss Islington (bot) <[email protected]>
committer: pablogsal <[email protected]>
date: 2026-09-25T20:10:12Z
summary:

[3.14] GH-144679: When building with VS 2026 on Windows, use PlatformToolset 
v145 by default (GH-144680) (#158188)

* GH-144679: When building with VS 2026 on Windows, use PlatformToolset v145 by 
default (GH-144680)
(cherry picked from commit c06f4f43015528db45bd6b44b46c057d88b38583)

Co-authored-by: Chris Eibl <[email protected]>

* Silence experimental coroutine deprecation warnings (#150788)

Co-authored-by: Zachary Ware <[email protected]>
(cherry picked from commit 7241db11699f74d2e90d04cdaa8ecde2ffcfc7bf)

---------

Co-authored-by: Chris Eibl <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Zachary Ware <[email protected]>

files:
A Misc/NEWS.d/next/Build/2026-02-10-18-26-04.gh-issue-144679.FIH73W.rst
M PC/python_uwp.cpp
M PCbuild/python.props
M PCbuild/pythoncore.vcxproj
M Tools/msi/bundle/bootstrap/pythonba.vcxproj

diff --git 
a/Misc/NEWS.d/next/Build/2026-02-10-18-26-04.gh-issue-144679.FIH73W.rst 
b/Misc/NEWS.d/next/Build/2026-02-10-18-26-04.gh-issue-144679.FIH73W.rst
new file mode 100644
index 00000000000000..ebcfda54da39a7
--- /dev/null
+++ b/Misc/NEWS.d/next/Build/2026-02-10-18-26-04.gh-issue-144679.FIH73W.rst
@@ -0,0 +1,2 @@
+When building with Visual Studio 2026 (Version 18), use PlatformToolSet v145
+by default. Patch by Chris Eibl.
diff --git a/PC/python_uwp.cpp b/PC/python_uwp.cpp
index b9c408a580c999..04174222ea8998 100644
--- a/PC/python_uwp.cpp
+++ b/PC/python_uwp.cpp
@@ -13,6 +13,7 @@
 #if defined(__clang__)
 #define _SILENCE_CLANG_COROUTINE_MESSAGE
 #endif
+#define _SILENCE_EXPERIMENTAL_COROUTINE_DEPRECATION_WARNINGS
 
 #include <appmodel.h>
 #include <winrt\Windows.ApplicationModel.h>
diff --git a/PCbuild/python.props b/PCbuild/python.props
index 8ed6269b89149d..15c120302a456e 100644
--- a/PCbuild/python.props
+++ b/PCbuild/python.props
@@ -11,7 +11,7 @@
 
     We set BasePlatformToolset for ICC's benefit, it's otherwise ignored.
     -->
-    <BasePlatformToolset Condition="'$(BasePlatformToolset)' == '' and 
'$(VisualStudioVersion)' == '18.0'">v143</BasePlatformToolset>
+    <BasePlatformToolset Condition="'$(BasePlatformToolset)' == '' and 
'$(VisualStudioVersion)' == '18.0'">v145</BasePlatformToolset>
     <BasePlatformToolset Condition="'$(BasePlatformToolset)' == '' and 
'$(VisualStudioVersion)' == '17.0'">v143</BasePlatformToolset>
     <BasePlatformToolset Condition="'$(BasePlatformToolset)' == '' and 
'$(VisualStudioVersion)' == '16.0'">v142</BasePlatformToolset>
     <BasePlatformToolset Condition="'$(BasePlatformToolset)' == '' and 
('$(MSBuildToolsVersion)' == '15.0' or '$(VisualStudioVersion)' == 
'15.0')">v141</BasePlatformToolset>
diff --git a/PCbuild/pythoncore.vcxproj b/PCbuild/pythoncore.vcxproj
index b911c9385634d7..69d83764fbe94b 100644
--- a/PCbuild/pythoncore.vcxproj
+++ b/PCbuild/pythoncore.vcxproj
@@ -716,7 +716,7 @@
       </ClCompile>
     </ItemGroup>
   </Target>
-  <Target Name="_WarnAboutToolset" BeforeTargets="PrepareForBuild" 
Condition="$(PlatformToolset) != 'v141' and $(PlatformToolset) != 'v142' and 
$(PlatformToolset) != 'v143'">
+  <Target Name="_WarnAboutToolset" BeforeTargets="PrepareForBuild" 
Condition="$(PlatformToolset) != 'v143' and $(PlatformToolset) != 'v145'">
     <Warning Text="Toolset $(PlatformToolset) is not used for official builds. 
Your build may have errors or incompatibilities." />
   </Target>
   <Target Name="_WarnAboutZlib" BeforeTargets="PrepareForBuild" 
Condition="!$(IncludeExternals)">
diff --git a/Tools/msi/bundle/bootstrap/pythonba.vcxproj 
b/Tools/msi/bundle/bootstrap/pythonba.vcxproj
index 3970e857894ba5..4b38582f0d31e5 100644
--- a/Tools/msi/bundle/bootstrap/pythonba.vcxproj
+++ b/Tools/msi/bundle/bootstrap/pythonba.vcxproj
@@ -21,6 +21,7 @@
   <PropertyGroup Label="Globals">
     <Configuration Condition="'$(Configuration)' == ''">Release</Configuration>
     <Platform Condition="'$(Platform)' == ''">Win32</Platform>
+    <PlatformToolset Condition="'$(PlatformToolset)' == '' and 
'$(VisualStudioVersion)' == '18.0'">v145</PlatformToolset>
     <PlatformToolset Condition="'$(PlatformToolset)' == '' and 
'$(VisualStudioVersion)' == '17.0'">v143</PlatformToolset>
     <PlatformToolset Condition="'$(PlatformToolset)' == '' and 
'$(VisualStudioVersion)' == '16.0'">v142</PlatformToolset>
     <PlatformToolset Condition="'$(PlatformToolset)' == '' and 
('$(MSBuildToolsVersion)' == '15.0' or '$(VisualStudioVersion)' == 
'15.0')">v141</PlatformToolset>

_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3//lists/python-checkins.python.org
Member address: [email protected]

Reply via email to