https://github.com/python/cpython/commit/24dfd639cd81cc0252391ed15354d64c561e7dd2 commit: 24dfd639cd81cc0252391ed15354d64c561e7dd2 branch: 3.14 author: Miss Islington (bot) <[email protected]> committer: hugovk <[email protected]> date: 2026-10-23T21:21:45+03:00 summary:
[3.14] gh-157621: Clear weakrefs for ParamSpec attributes (GH-157622) (#157654) Co-authored-by: Samartha <[email protected]> files: A Misc/NEWS.d/next/Library/2026-09-16-14-04-38.gh-issue-157621.R6v2S8.rst M Lib/test/test_typing.py M Objects/typevarobject.c diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py index f97e925016f03c..4187006c09cafb 100644 --- a/Lib/test/test_typing.py +++ b/Lib/test/test_typing.py @@ -10092,6 +10092,17 @@ def test_args_kwargs(self): self.assertEqual(repr(P.args), "P.args") self.assertEqual(repr(P.kwargs), "P.kwargs") + def test_args_kwargs_weakrefs(self): + P = ParamSpec('P') + for attr_name in ('args', 'kwargs'): + with self.subTest(attr_name=attr_name): + callback_fired = [] + attr = getattr(P, attr_name) + ref = weakref.ref(attr, lambda _: callback_fired.append(True)) + del attr + self.assertEqual(callback_fired, [True]) + self.assertIsNone(ref()) + def test_stringized(self): P = ParamSpec('P') class C(Generic[P]): diff --git a/Misc/NEWS.d/next/Library/2026-09-16-14-04-38.gh-issue-157621.R6v2S8.rst b/Misc/NEWS.d/next/Library/2026-09-16-14-04-38.gh-issue-157621.R6v2S8.rst new file mode 100644 index 00000000000000..b8342da0faebb9 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2026-09-16-14-04-38.gh-issue-157621.R6v2S8.rst @@ -0,0 +1,2 @@ +Fix a crash when a weak-reference callback is attached to a +:class:`typing.ParamSpecArgs` or :class:`typing.ParamSpecKwargs` instance. diff --git a/Objects/typevarobject.c b/Objects/typevarobject.c index 97e913b6c268c0..9da0e3217377ae 100644 --- a/Objects/typevarobject.c +++ b/Objects/typevarobject.c @@ -952,6 +952,7 @@ paramspecattr_dealloc(PyObject *self) _PyObject_GC_UNTRACK(self); Py_XDECREF(psa->__origin__); + PyObject_ClearWeakRefs(self); Py_TYPE(self)->tp_free(self); Py_DECREF(tp); _______________________________________________ Python-checkins mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3//lists/python-checkins.python.org Member address: [email protected]
