https://github.com/python/cpython/commit/c5d09789ea28f34b9f150a4d033945e0eccaeabf
commit: c5d09789ea28f34b9f150a4d033945e0eccaeabf
branch: main
author: Stan Ulbrych <[email protected]>
committer: StanFromIreland <[email protected]>
date: 2026-10-26T14:37:44Z
summary:
Fix ignored error returns in `sys` initialization, `_ctypes` and
`_interpchannels` (#160614)
files:
M Modules/_ctypes/_ctypes.c
M Modules/_interpchannelsmodule.c
M Python/pylifecycle.c
M Python/sysmodule.c
diff --git a/Modules/_ctypes/_ctypes.c b/Modules/_ctypes/_ctypes.c
index a2e5cbab10944b8..1035c91005759df 100644
--- a/Modules/_ctypes/_ctypes.c
+++ b/Modules/_ctypes/_ctypes.c
@@ -2479,22 +2479,30 @@ PyCSimpleType_init(PyObject *self, PyObject *args,
PyObject *kwds)
}
assert(sw_info);
#ifdef WORDS_BIGENDIAN
- PyObject_SetAttrString(self, "__ctype_le__", swapped);
- PyObject_SetAttrString(self, "__ctype_be__", self);
- PyObject_SetAttrString(swapped, "__ctype_be__", self);
- PyObject_SetAttrString(swapped, "__ctype_le__", swapped);
+ if (PyObject_SetAttrString(self, "__ctype_le__", swapped) < 0 ||
+ PyObject_SetAttrString(self, "__ctype_be__", self) < 0 ||
+ PyObject_SetAttrString(swapped, "__ctype_be__", self) < 0 ||
+ PyObject_SetAttrString(swapped, "__ctype_le__", swapped) < 0)
+ {
+ Py_DECREF(swapped);
+ return -1;
+ }
/* We are creating the type for the OTHER endian */
sw_info->format = _ctypes_alloc_format_string("<", stginfo->format+1);
#else
- PyObject_SetAttrString(self, "__ctype_be__", swapped);
- PyObject_SetAttrString(self, "__ctype_le__", self);
- PyObject_SetAttrString(swapped, "__ctype_le__", self);
- PyObject_SetAttrString(swapped, "__ctype_be__", swapped);
+ if (PyObject_SetAttrString(self, "__ctype_be__", swapped) < 0 ||
+ PyObject_SetAttrString(self, "__ctype_le__", self) < 0 ||
+ PyObject_SetAttrString(swapped, "__ctype_le__", self) < 0 ||
+ PyObject_SetAttrString(swapped, "__ctype_be__", swapped) < 0)
+ {
+ Py_DECREF(swapped);
+ return -1;
+ }
/* We are creating the type for the OTHER endian */
sw_info->format = _ctypes_alloc_format_string(">", stginfo->format+1);
#endif
Py_DECREF(swapped);
- if (PyErr_Occurred()) {
+ if (sw_info->format == NULL) {
return -1;
}
};
diff --git a/Modules/_interpchannelsmodule.c b/Modules/_interpchannelsmodule.c
index 18f892406d10b99..930d7276a3ed45e 100644
--- a/Modules/_interpchannelsmodule.c
+++ b/Modules/_interpchannelsmodule.c
@@ -2638,7 +2638,7 @@ _channelid_shared(PyThreadState *tstate, PyObject *obj,
_PyXIData_t *data)
if (st == NULL) {
return -1;
}
- if (!PyObject_IsInstance(obj, (PyObject *)st->ChannelIDType)) {
+ if (!PyObject_TypeCheck(obj, st->ChannelIDType)) {
PyErr_Format(PyExc_TypeError,
"'_id' attribute must be an %N object, not %T",
st->ChannelIDType, obj);
diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c
index 4df8c2d342beb22..876e52604c7f8e7 100644
--- a/Python/pylifecycle.c
+++ b/Python/pylifecycle.c
@@ -3211,8 +3211,14 @@ init_sys_streams(PyThreadState *tstate)
config->stdio_errors);
if (std == NULL)
goto error;
- PySys_SetObject("__stdin__", std);
- _PySys_SetAttr(&_Py_ID(stdin), std);
+ if (PySys_SetObject("__stdin__", std) < 0) {
+ Py_DECREF(std);
+ goto error;
+ }
+ if (_PySys_SetAttr(&_Py_ID(stdin), std) < 0) {
+ Py_DECREF(std);
+ goto error;
+ }
Py_DECREF(std);
/* Set sys.stdout */
@@ -3222,8 +3228,14 @@ init_sys_streams(PyThreadState *tstate)
config->stdio_errors);
if (std == NULL)
goto error;
- PySys_SetObject("__stdout__", std);
- _PySys_SetAttr(&_Py_ID(stdout), std);
+ if (PySys_SetObject("__stdout__", std) < 0) {
+ Py_DECREF(std);
+ goto error;
+ }
+ if (_PySys_SetAttr(&_Py_ID(stdout), std) < 0) {
+ Py_DECREF(std);
+ goto error;
+ }
Py_DECREF(std);
#if 1 /* Disable this if you have trouble debugging bootstrap stuff */
diff --git a/Python/sysmodule.c b/Python/sysmodule.c
index ce75027f67e9f4f..6f336dac058379e 100644
--- a/Python/sysmodule.c
+++ b/Python/sysmodule.c
@@ -4380,8 +4380,12 @@ _PySys_Create(PyThreadState *tstate, PyObject **sysmod_p)
PyUnstable_Module_SetGIL(sysmod, Py_MOD_GIL_NOT_USED);
#endif
- PyModule_AddIntMacro(sysmod, EXIT_SUCCESS);
- PyModule_AddIntMacro(sysmod, EXIT_FAILURE);
+ if (PyModule_AddIntMacro(sysmod, EXIT_SUCCESS) < 0) {
+ goto error;
+ }
+ if (PyModule_AddIntMacro(sysmod, EXIT_FAILURE) < 0) {
+ goto error;
+ }
PyObject *sysdict = PyModule_GetDict(sysmod);
if (sysdict == NULL) {
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3//lists/python-checkins.python.org
Member address: [email protected]
