https://github.com/python/cpython/commit/49c43f7de0c31c65e4128118dc989754fcace54d commit: 49c43f7de0c31c65e4128118dc989754fcace54d branch: main author: Duprat <[email protected]> committer: asvetlov <[email protected]> date: 2026-11-05T12:17:09+01:00 summary:
gh-155233: Fix asyncio.Barrier reusing a cancelled task's index (alternative to GH-155235) (#158957) * Initial commit: - add a private ``_index`` attr - add a test Co-authored-by: Sreehari Annam * 📜🤖 Added by blurb_it. * Apply suggestions from code review * Update Lib/asyncio/locks.py * Update Lib/asyncio/locks.py --------- Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Andrew Svetlov <[email protected]> files: A Misc/NEWS.d/next/Library/2026-10-07-10-59-27.gh-issue-155233.YGuQGK.rst M Lib/asyncio/locks.py M Lib/test/test_asyncio/test_locks.py diff --git a/Lib/asyncio/locks.py b/Lib/asyncio/locks.py index c59ea15111bef2..f2cf7c72ee8ed3 100644 --- a/Lib/asyncio/locks.py +++ b/Lib/asyncio/locks.py @@ -489,6 +489,8 @@ def __init__(self, parties): self._parties = parties self._state = _BarrierState.FILLING self._count = 0 # count tasks in Barrier + # index number returned when barrier drains + self._index = self._parties - 1 def __repr__(self): res = super().__repr__() @@ -515,13 +517,14 @@ async def wait(self): async with self._cond: await self._block() # Block while the barrier drains or resets. try: - index = self._count self._count += 1 - if index + 1 == self._parties: + if self._count == self._parties: # We release the barrier await self._release() else: await self._wait() + index = self._index + self._index = (self._index + 1) % self._parties return index finally: self._count -= 1 @@ -569,6 +572,7 @@ def _exit(self): if self._count == 0: if self._state in (_BarrierState.RESETTING, _BarrierState.DRAINING): self._state = _BarrierState.FILLING + self._index = self._parties - 1 self._cond.notify_all() async def reset(self): @@ -584,6 +588,7 @@ async def reset(self): self._state = _BarrierState.RESETTING else: self._state = _BarrierState.FILLING + self._index = self._parties - 1 self._cond.notify_all() async def abort(self): diff --git a/Lib/test/test_asyncio/test_locks.py b/Lib/test/test_asyncio/test_locks.py index 320a933e144813..f0e779c7a80409 100644 --- a/Lib/test/test_asyncio/test_locks.py +++ b/Lib/test/test_asyncio/test_locks.py @@ -1820,6 +1820,36 @@ async def coro(): self.assertEqual(barrier1.n_waiting, 0) + async def test_filling_tasks_cancel_one_index_still_unique(self): + # See gh-155233: a task cancelled while the barrier is still + # filling used to leave its index available for reuse. + # Index counter is now calculated on demand during the draining phasis. + self.N = 3 + barrier = asyncio.Barrier(self.N) + results = [] + + async def coro(): + i = await barrier.wait() + results.append(i) + + t1 = asyncio.create_task(coro()) + t2 = asyncio.create_task(coro()) + await asyncio.sleep(0) + self.assertEqual(barrier.n_waiting, 2) + + t1.cancel() + with self.assertRaises(asyncio.CancelledError): + await t1 + await asyncio.sleep(0) + self.assertEqual(barrier.n_waiting, 1) + + t3 = asyncio.create_task(coro()) + t4 = asyncio.create_task(coro()) + await asyncio.gather(t2, t3, t4) + + self.assertEqual(sorted(results), list(range(self.N))) + self.assertEqual(barrier.n_waiting, 0) + if __name__ == '__main__': unittest.main() diff --git a/Misc/NEWS.d/next/Library/2026-10-07-10-59-27.gh-issue-155233.YGuQGK.rst b/Misc/NEWS.d/next/Library/2026-10-07-10-59-27.gh-issue-155233.YGuQGK.rst new file mode 100644 index 00000000000000..ebcd4a4bc29a5c --- /dev/null +++ b/Misc/NEWS.d/next/Library/2026-10-07-10-59-27.gh-issue-155233.YGuQGK.rst @@ -0,0 +1 @@ +Fix :meth:`asyncio.Barrier.wait` returning duplicate indices when a waiting task is cancelled before the barrier is released.``` _______________________________________________ Python-checkins mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3//lists/python-checkins.python.org Member address: [email protected]
