On Mon, 2010-11-08 at 12:22 +0000, Michael Foord wrote: > On 08/11/2010 12:18, Łukasz Langa wrote: > > Am 08.11.2010 12:55, schrieb Michael Foord: > >> On 08/11/2010 11:42, Senthil Kumaran wrote: > >>> We can just customize our environments. It is easy. > > > > I already pointed out in my last post why that's not going to solve > > the problem. > > > >> Additional checks could be put in `make patchcheck` or a local commit > >> hook for hg. > > > > Automation always pays off. Simplifying the process always pays off. > > Providing yet another step to the workflow would be a move in the > > opposite direction*. > > You mean `make patchcheck` isn't *already* part of your workflow?
FWIW, "make patchcheck" isn't mentioned on the "Python Patch Submission Guidelines" here: http://www.python.org/dev/patches/ and doesn't seem to be mentioned anywhere on the website. I'm attaching a patch (to the website) that adds this to that page. (snip)
Index: data/dev/patches/content.ht =================================================================== --- data/dev/patches/content.ht (revision 13459) +++ data/dev/patches/content.ht (working copy) @@ -40,6 +40,13 @@ or documentation; it's better to use the same issue and keep all discussion in one place. +* Please run "make patchcheck" before submitting your patch. This is a + checklist of common issues with patches. It will try to enforce whitespace + rules in the files you changed. It will also remind you to run the test + suite, and remind you if you haven't edited the documentation, ``Misc/ACKS`` + or ``Misc/NEWS``. + + Python Patch Style Guidelines -----------------------------
_______________________________________________ python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
