If someone makes a review on github (as opposed to a simple comment) I believe the state of the code as it was when that review as made can be viewed by hitting the “View Changes” button next to that review in the timeline.
> On Apr 10, 2017, at 3:18 PM, Guido van Rossum <gu...@python.org> wrote: > > Thanks for the clarification. We should probably move this discussion to the > python-committers list rather than core-mentorship. > > On Mon, Apr 10, 2017 at 12:12 PM, Terry Reedy <tjre...@udel.edu > <mailto:tjre...@udel.edu>> wrote: > On 4/10/2017 12:54 PM, Guido van Rossum wrote: > So the response from Martin Panter > (https://github.com/python/cpython/pull/851#issuecomment-292755992 > <https://github.com/python/cpython/pull/851#issuecomment-292755992>) > sounds like he's not set up for the new GitHub workflow. I'm CC'ing > Martin here. > > The specific issue Martin raised is "Sorry but I don’t have an easy way to > see your fixes relative to the old version I reviewed." If the original and > modified patches were posted in proper format to b.p.o., then one could hit > [review] to start Rietveld and request a side-by-side diff of the two > versions. This is perfect for reviewing responses to comments, especially > those made in-line. For this issue, Martin made about 20 inline comments. > > I don't see any way to get the equivalent on a github PR. It appears that > the original patch is replaced by the revised patch. To me, Rietveld was a > great review tool and its loss a regression in the work process. I hope that > this can be fixed somehow. > > tjr > > > > _______________________________________________ > Core-mentorship mailing list > core-mentors...@python.org <mailto:core-mentors...@python.org> > https://mail.python.org/mailman/listinfo/core-mentorship > <https://mail.python.org/mailman/listinfo/core-mentorship> > > > > -- > --Guido van Rossum (python.org/~guido <http://python.org/~guido>) > _______________________________________________ > python-committers mailing list > python-committers@python.org > https://mail.python.org/mailman/listinfo/python-committers > Code of Conduct: https://www.python.org/psf/codeofconduct/ — Donald Stufft
_______________________________________________ python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
