On Wed, Sep 20, 2017 at 2:49 PM, Victor Stinner <victor.stin...@gmail.com> wrote:
> > I think it's a good idea in many cases, but not required. > > I'm not sure that I understood correctly, what is a good idea? To > merge the PR if I consider that it's now good enough to be merged? > Sorry, yes. > E.g. you may be OK > > with the diff but still ask the author to clean up some small nits, and > then > > they can merge their own diff. > > Oh, my question was specific to a PR at the "LGTM." stage, after I > even approved the PR. > > I wrote my email after approving > https://github.com/python/cpython/pull/3678 which is written by > Antoine Pitrou. I asked a question, he replied, I like his answer. The > patch is small and makes sense. So LGTM :-) > > > Or you may be OK with the diff but want to > > wait for some other reviewer's OK. > > Yeah, it's not uncommon that I prefer to get a second review. Usually, > I explicitly say it in a comment. > > > The good news is that it's no longer wrong, since the author is preserved > > regardless of who merges. > > Yep, that's my point :-) > Seems we're in violent agreement! :-) -- --Guido van Rossum (python.org/~guido)
_______________________________________________ python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
