There's probably an argument for being consistent, though. If there's only a single one of them in a given file, it may mean it's an accident. The best thing may be to "git annotate" who added it and ask them.
I don't remember the _io module having form feed characters in its source code. But I haven't worked on it in a long time... cheers Antoine. Le 18/11/2019 à 19:47, Eric V. Smith a écrit : > Replying to python-committers for visibility, although maybe python-dev > would be better. > > That's not a "strange non-ASCII character"! That's a form feed > (control-L), definitely defined by ASCII. > > There are plenty of these in the code. Some people (who won't be named, > but match the regex "Barry") like them. I don't think we should start > removing them. > > Eric > > On 11/18/2019 1:40 PM, Tal Einat wrote: >> https://github.com/python/cpython/commit/bcc1cc5cc38b57ac55cbe710849374258d610a08 >> commit: bcc1cc5cc38b57ac55cbe710849374258d610a08 >> branch: master >> author: Tal Einat <taleinat+git...@gmail.com> >> committer: GitHub <nore...@github.com> >> date: 2019-11-18T20:39:47+02:00 >> summary: >> >> remove a strange non-ASCII character in _iomodule.c (GH-17239) >> >> files: >> M Modules/_io/_iomodule.c >> >> diff --git a/Modules/_io/_iomodule.c b/Modules/_io/_iomodule.c >> index 5932363f3af35..778b56d475ee5 100644 >> --- a/Modules/_io/_iomodule.c >> +++ b/Modules/_io/_iomodule.c >> @@ -503,7 +503,7 @@ _io_open_code_impl(PyObject *module, PyObject *path) >> { >> return PyFile_OpenCodeObject(path); >> } >> - >> + >> /* >> * Private helpers for the io module. >> */ >> >> _______________________________________________ >> Python-checkins mailing list >> python-check...@python.org >> https://mail.python.org/mailman/listinfo/python-checkins > _______________________________________________ > python-committers mailing list -- python-committers@python.org > To unsubscribe send an email to python-committers-le...@python.org > https://mail.python.org/mailman3/lists/python-committers.python.org/ > Message archived at > https://mail.python.org/archives/list/python-committers@python.org/message/GN5NRNWNPHOSLLQWNRDZGJPPT6KPRMMX/ > Code of Conduct: https://www.python.org/psf/codeofconduct/ > _______________________________________________ python-committers mailing list -- python-committers@python.org To unsubscribe send an email to python-committers-le...@python.org https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/37ZRGCRK5KBLHMONCZVVMQHQ7WFFCPAZ/ Code of Conduct: https://www.python.org/psf/codeofconduct/
