On 03Apr2020 1948, Nathaniel Smith wrote:
On Fri, Apr 3, 2020 at 11:32 AM Victor Stinner <vstin...@python.org> wrote:
I had to update the OpenSSL version in the CI configuration which
lives in the same Git repository than Python code base. Since our CI
currently runs on unmodified PRs, maybe the 1090 pending pull requests
must now be rebased manually on the master branch to get these CI
configuration updates. Otherwise, the CI would fail which prevents to
merge a PR. I'm not sure at this point.
In general CI systems run on merge(PR-head, target-branch-head),
rather than directly on PR-head. So this may not be an issue at all.
The CI configuration is loaded from the PR head, at least on GitHub
Actions (where you can validate config changes in PR) and Azure
Pipelines. I just validated this by re-running an old PR and watched it
choose OpenSSL 1.1.1d instead of 1.1.1f (and then fail to check out a
reference - see the logs at
https://github.com/python/cpython/pull/18909/checks?check_run_id=564079685)
So I think it's an issue, and probably does require PRs to merge in
master to get back in sync. But probably the best we can do is post a
message in older PRs warning that they need to do it. Maybe we close
them at the same time?
We could also move some of these CI configuration variables out of the
CI files and into separate scripts - many already are. This is annoying
for anyone who forks and runs their own build, but it should mean that
updates like the OpenSSL version get merged in during CI even for older PRs.
Cheers,
Steve
_______________________________________________
python-committers mailing list -- python-committers@python.org
To unsubscribe send an email to python-committers-le...@python.org
https://mail.python.org/mailman3/lists/python-committers.python.org/
Message archived at
https://mail.python.org/archives/list/python-committers@python.org/message/Y4IHDFSVRC7NN4GJ3YQUUTNQA7ZGTCEK/
Code of Conduct: https://www.python.org/psf/codeofconduct/
