On Sun, Oct 11, 2020 at 10:13 PM Gregory P. Smith <g...@krypto.org> wrote: > > We've got the automerge tag on GH, it+bot make it awesome. There's one more > thing I'd like to see that could help with bug hygiene: A tag to close the > associated bug as "fixed" after the merge happens. > > This doesn't have to be tied to automerge; in practice you'd find them used > in unison somewhat often. More readily on features done on the main branch > rather than bug fixes needing backports to multiple releases. > > We've had such a system at work for so long I don't even remember when it was > added, but it has been a great time saver. Less more bugs laying around fixed > but not marked as such. Less need for triagers to manually ask someone who > has the permissions to change the bug state. Less unintentionally still open > bugs in the way distracting people. Good all around. > > It isn't the primary way to close issues, but it helps in situations where it > makes sense. I'd assume the same set of people allowed to add automerge > should be allowed to add this label.
I've been taking advantage of the need to go to the bpo issue to close it for two things: 1. Final review of the issue, making sure there isn't anything else that came up in its comments that warrants further attention. 2. Thanking the reporter, patch/PR submitters and others who contributed. I've come to think that #2 is especially important. This is a difference with a project like ours vs. a work environment: At a workplace, there usually isn't a need to thank people for their work on an issue, so just making sure that status is updated is enough. Therefore, I'd only use such a feature to close issues I opened myself when merging my own PRs which resolve them. - Tal _______________________________________________ python-committers mailing list -- python-committers@python.org To unsubscribe send an email to python-committers-le...@python.org https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/USAHA4H4SU7MYY4YYB35KHY5CY5XWWJJ/ Code of Conduct: https://www.python.org/psf/codeofconduct/
