It has not much impact since I simply don't use configure, nor make. To build under Windows XP, I just launch the Python script in dist\setup.py.in .
Note the .in extension, which seems to mean that it should have been transformed by another script. However, when having a look at the script, I do not see any @@ macro. So I guess it's safe for it to be launched as is.
The macro processing done by configure looks for any file ending in .in, makes the macro substitutions (anything enclosed by @@) and creates a new file with the .in extension stripped off.
In fact it seems that we could solve all our versioning issues by tweaking this setup.py.in script.
Looking at setup.py, there is already a function (getmp_version) which parses mpversion.h, so we're half way there. Just need to add another function to do dump the version string into __init__.py.
Probably worth waiting for the patches from David Fraser though. See: http://issues.apache.org/jira/browse/MODPYTHON-55?page=comments#action_65861
Jim
Regards, Nicolas
2005/5/20, Jim Gallacher <[EMAIL PROTECTED]>:
Nicolas Lehuen wrote:
The problem is that this won't work when building on Windows. I think we should use Python scripts instead of configure, grep et al which are not truly portable (well, I hear you, portable everywhere except on Windows :)).
Use python? PYTHON???? Well, the very idea... :)
Same principal, different tool. I'd still be willing to take a shot at it.
Just curious - how does the use of awk and sed in configure impact building on Windows?
Regards, Jim
2005/5/20, Jim Gallacher (JIRA) <[EMAIL PROTECTED]>:
[ http://issues.apache.org/jira/browse/MODPYTHON-55?page=comments#action_65861 ]
Jim Gallacher commented on MODPYTHON-55: ----------------------------------------
Would it be appropriate to determine the version at configure time?
If so we could create a file mod_python/__init__.py.in which would contain: version="@MP_VERSION@"
and configure would grep src/include/mpversion.h for MPV_STRING and generate __init__.py from __init__.py.in.
If this seems reasonable I can put something together.
Add a version attribute to the mod_python module. -------------------------------------------------
Key: MODPYTHON-55 URL: http://issues.apache.org/jira/browse/MODPYTHON-55 Project: mod_python Type: Improvement Versions: 3.1.4 Reporter: Nicolas Lehuen Assignee: Nicolas Lehuen Fix For: 3.2.0
(asked by dharana) There is no easy way to know the version of mod_python used from within an handler. Why not try to add a version string attribute to the mod_python module ?
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
