In fact, I was a little bit on hurry when I posted my patch and did a 'svn
diff' but you are right, the file generated by flex should not be included
into the patch, just the file used to generate it should be included. But
if I remember correctly, I had to regenerate this file as it produces a
file where the Python.h (or pyconfig.h) is not included first.
I'll try to have a look again.
Michel
--On mardi 21 février 2006 07:51 +0100 Nicolas Lehuen <[EMAIL PROTECTED]>
wrote:
Er... I should say that the changes in _pspmodule.c are fine, so they
should be integrated. The problems are in the changes brought to the
files that are generated by flex. First, they break on Win32, second,
since the .l source file is unchanged, next time flex is run the
changes will be overwritten.
Regards,
Nicolas
2006/2/21, Nicolas Lehuen <[EMAIL PROTECTED]>:
Hi Michel,
I've tested your patch on Win32 + Apache 2.2 and it mostly works
(compilation + unit tests) - except for the changes in the PSP lexer &
parser. They now includ unistd.h which was previously hidden for Win32
platforms.It looks like you have generated those files from the .l
grammar using flex, maybe it was an old version ? In any case, I don't
understand what those changes have to do with the problem you
reported.
So my position would be to integrate your patch except for the PSP part.
Regards,
Nicolas
2006/2/20, Jim Gallacher <[EMAIL PROTECTED]>:
> Hi Michel,
>
> Please create a JIRA issue. We are much less likely to loose track of
> it if it's in the issue tracker.
>
> Thanks,
> Jim
>
>
> Michel Jouvin wrote:
> > 0 Tru64 5.1B-3, Apache 2.0.55, worker MPM, Python 2.4.1
> >
> > I have a problem to build mod_pyton on Tru64 with the Python config I
> > have. This is basically due to the fact that Python.h should be
> > included first as its defines some macros used by standard includes.
> > When included at the end of the includes, this results to some
> > conflicts because the same include is included twice with a
> > different macro value.
> >
> > I reported this a couple of months ago during 3.2 beta. Do you want
> > me to resubmit this problem via JIRA ? Or just to resend the
> > required fixes ?
> >
> > Cheers,
> >
> > Michel
> >
> > --On lundi 20 février 2006 16:18 -0500 Graham Dumpleton
> > <[EMAIL PROTECTED]> wrote:
> >
> >> +1 core vote
> >>
> >> Nicolas Lehuen wrote ..
> >>
> >>> +1 core vote
> >>>
> >>> 2006/2/20, Jim Gallacher <[EMAIL PROTECTED]>:
> >>> > +1 core vote
> >>> >
> >>> > Jim
> >>> >
> >>> > Gregory (Grisha) Trubetskoy wrote:
> >>> > >
> >>> > > Based on summary below, +1 from for putting it out there.
> >>> > >
> >>> > > Grisha
> >>> > >
> >>> > >
> >>> > > Graham Dumpleton <[EMAIL PROTECTED]>
> >>> > > +1 Mac OS X 10.4, apache 2.0.55 mpm-worker, python 2.3.5
> >>> > > (3.2.x
> >>> SVN
> >>> > > trunk)
> >>> > >
> >>> > > Nicolas Lehuen <[EMAIL PROTECTED]>
> >>> > > +1 mod_python 3.2.8 + Apache/2.0.55 + Python/2.2.3 + Windows
> >>> > > 2000
> >>> SP4
> >>> > > +1 mod_python 3.2.8 + Apache/2.0.55 + ActivePython/2.3.5 +
> >>> > > Windows 2000 SP4
> >>> > > +1 mod_python 3.2.8 + Apache/2.0.55 + ActivePython/2.4.2 +
> >>> > > Windows
> >>> XP SP2
> >>> > >
> >>> > > Barry Pederson <[EMAIL PROTECTED]>
> >>> > > +1 FreeBSD 6.0, apache 2.0.55 mpm-prefork, python 2.4.2
> >>> > >
> >>> > > Jim Gallacher <[EMAIL PROTECTED]>
> >>> > > +1 Debian sid, apache 2.0.55 mpm-prefork, python 2.3.5
> >>> > >
> >>> > >
> >>> >
> >>> >
> >
> >
> >
> >
> > *************************************************************
> > * Michel Jouvin Email : [EMAIL PROTECTED] *
> > * LAL / CNRS Tel : +33 1 64468932 *
> > * B.P. 34 Fax : +33 1 69079404 *
> > * 91898 Orsay Cedex *
> > * France *
> > *************************************************************
> >
> >
> >
>
>
*************************************************************
* Michel Jouvin Email : [EMAIL PROTECTED] *
* LAL / CNRS Tel : +33 1 64468932 *
* B.P. 34 Fax : +33 1 69079404 *
* 91898 Orsay Cedex *
* France *
*************************************************************
