Code for deriving base URL/directory for request using wrong value???

                 Key: MODPYTHON-216
             Project: mod_python
          Issue Type: Bug
          Components: core
    Affects Versions: 3.3
            Reporter: Graham Dumpleton
            Priority: Minor

In determine_context() of src/mod_python.c, the code pertaining to Directory 

        if (!strcmp(directory, "~")) {
            directory = ap_getword_conf(p, &arg);
            d_regex = ap_pregcomp(p, cmd->path, AP_REG_EXTENDED|USE_ICASE);
        } else if (ap_is_matchexp(directory)) {
            d_is_fnmatch = 1;

and that for Location has:

        if (!strcmp(location, "~")) {
            location = ap_getword_conf(p, &arg);
            l_regex = ap_pregcomp(p, cmd->path, AP_REG_EXTENDED|USE_ICASE);
        } else if (ap_is_matchexp(location)) {
            l_is_fnmatch = 1;

In both cases, the pattern used to compile the regular expression is the value 
of cmd->path.

These perhaps should be 'directory' and 'location' respectively, but then 
cmd->path may be the same thing anyway.

No actual problems have been see with code because of this, but should be 
verified anyway.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to