Neal Norwitz wrote:
I would like feedback on whether the approach is desirable.
I'm probably missing something really essential, but...
Where are the Py_DECREFs done for the function arguments?
Also, changing PyArg_ParseTuple is likely incorrect.
Currently, chr/unichr expects float values; with your
change, I believe it won't anymore.
Apart from that, the change looks fine to me.
Regards,
Martin
_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
