On 4-jan-2006, at 0:51, Bob Ippolito wrote:
>
> On Jan 3, 2006, at 3:12 PM, Martin v. Löwis wrote:
>
>> Bob Ippolito wrote:
>>> Who's going to bother?
>>
>> It violates PEP 7, unless you argue that OS X/gcc is not
>> a "major compiler".
>
> Clearly, but that still doesn't answer the question of who's going to
> do it. Writing two code paths with availability macros and all the
> testing involved is a whole lot of work to fix a harmless warning on
> older versions of the OS. If it actually caused a problem I'm sure
> someone would go through the trouble, but in this case it's probably
> not worth the effort.
More energy seems to be spent on talking about this than implementing
the required patch :-)
This should do it, although I haven't tested this on OSX 10.3:
diff -u Python-2.4.2/Modules/getpath.c Python-2.4.2-orig/Modules/
getpath.c
--- Python-2.4.2/Modules/getpath.c 2006-01-04 21:06:17.000000000
+0100
+++ Python-2.4.2-orig/Modules/getpath.c 2004-08-08 03:00:47.000000000
+0200
@@ -381,12 +381,8 @@
NSModule pythonModule;
#endif
#ifdef __APPLE__
-#ifdef MAC_OS_X_VERSION_10_4
- uint32_t nsexeclength = MAXPATHLEN;
-#else
unsigned long nsexeclength = MAXPATHLEN;
#endif
-#endif
/* If there is no slash in the argv0 path, then we have to
* assume python is on the user's $PATH, since there's no
>
> -bob
>
> _______________________________________________
> Python-Dev mailing list
> [email protected]
> http://mail.python.org/mailman/listinfo/python-dev
> Unsubscribe: http://mail.python.org/mailman/options/python-dev/
> ronaldoussoren%40mac.com
_______________________________________________
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
