[Neal Norwitz wrote] > > [Fredrik Lundh wrote] > > > Can buildbot deal with custom test/validation scripts, and collect the > > > output > > > somewhere ? > > > ... > It looks like we could define a class similar to Test, such as: > > class Catalog(ShellCommand): > name = "catalog" > warnOnFailure = 0 # this was 1, not sure which we want > description = ["catalog"] > descriptionDone = ["catalog"] > command = ["/f cmd here", "and", "other", "flags"] > > The factory is created like this: > f = factory.GNUAutoconf(source, test=["make","testall"]) > > ISTM, we can just add this line: > f.steps.append(s(Catalog, command=Catalog.command)) > > Does that make sense? We would just need /f's script in SVN.
Yup. Sounds right to me. > PS If there was a method on ShellCommand, adding a step would be simpler, > e.g., > > def addStep(self, cls, **kwds): > self.steps.append((cls, kwds)) > > then we could do: f.addStep(Catalog, command=Catalog.command) > which would simplify a bunch of code in process/factory.py since it is > called this way 10 times. Didn't look elsewhere. Add a buildbot patch/bug? http://sourceforge.net/tracker/?func=add&group_id=73177&atid=537003 Trent -- Trent Mick [EMAIL PROTECTED] _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com