I agree - removing this just to make the coverage figures look pretty seems like the wrong motivation.
Configuring coverage to understand that you want to exclude these lines from the checking would be fine, as would accepting that a coverage of slightly less than 100% is OK. Removing functionality that people use (whether or not they have other ways of getting the same results) needs a stronger justification, IMO. Paul On Wed, 1 May 2019 at 11:51, Antoine Pitrou <solip...@pitrou.net> wrote: > > On Tue, 30 Apr 2019 22:24:53 +0100 > Chris Withers <ch...@withers.org> wrote: > > Hi All, > > > > I have a crazy idea of getting unittest.mock up to 100% code coverage. > > > > I noticed at the bottom of all of the test files in testmock/, there's a: > > > > if __name__ == '__main__': > > unittest.main() > > > > ...block. > > > > How would people feel about these going away? I don't *think* they're > > needed now that we have unittest discover, but thought I'd ask. > > If you are only asking to remove them because you want that score of > 100% coverage, then I think you shouldn't. > > Regards > > Antoine. > > > _______________________________________________ > Python-Dev mailing list > Python-Dev@python.org > https://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: > https://mail.python.org/mailman/options/python-dev/p.f.moore%40gmail.com _______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
