On Fri, Jun 21, 2019 at 1:28 AM Victor Stinner <vstin...@redhat.com> wrote: > > Le jeu. 20 juin 2019 à 11:15, Inada Naoki <songofaca...@gmail.com> a écrit : > > Can we change _PyUnicode_FromId to use _PyUnicode_FromASCII? > > How would a developer detect a mistake (non-ASCII) character? Does > _PyUnicode_FromASCII() raise an exception, even in release mode?
No. That's one of the reasons why _PyUnicode_FromASCII is much faster than PyUnicode_FromString(). > > The function is only called once (that's the whole purpose of the > Py_IDENTIFER() API. Is it really worth it? > Maybe no, at least for now. I just want to ask is it really worth it to support non-ASCII identifier, before we make it public or 3rd parties start using it widely. -- Inada Naoki <songofaca...@gmail.com> _______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/GCC5YDIPAIUT67EVKLGJ3INA24FRHNR5/
