I think it's fine for triagers to have the close permission, and there's actually a good reason to give it to them, which is that often the easiest way to trigger a new CI run is to close and re-open a PR. It will be very helpful for triagers to be able to do this to fix intermittent build problems and the like.
Even without the "trigger a new CI run" justification, I think the risk we're running by giving people close privileges is pretty minimal. If a PR is erroneously closed, it can just be re-opened. If a triager is consistently misuing /any/ of the permissions they are given, their triage permissions can be removed. Best, Paul On 8/22/19 6:02 AM, Victor Stinner wrote: > Hi, > > Oh, I just wrote a similar email to python-committers, I didn't notice > that Mariatta wrote to python-dev and python-committers. > > https://mail.python.org/archives/list/python-committ...@python.org/message/53K5MJAKLRGY2F34ZCYGL3WPWSJ4C5M2/ > > > My worry is more about closing pull requests. > > > Le 21/08/2019 à 22:13, Raymond Hettinger a écrit : >> The capabilities of a triager mostly look good except for "closing >> PRs and issues". This is a superpower that has traditionally been >> reserved for more senior developers because it grants the ability to >> shut-down the work of another aspiring contributor. Marking someone >> else's suggestion as rejected is the most perilous and least fun >> aspect of core development. Submitters tend to expect their idea >> won't be rejected without a good deal of thought and expert >> consideration. Our bar for becoming a triager is somewhat low, so I >> don't think it makes sense to give the authority to reject a PR or >> close an issue. > > Closing an issue (on GitHub) is not new compared to the previous > "Developer" role on bugs.python.org. When I gave the bug triage > permission to a contributor, I always warned them that closing an > issue is the most risky operation. I asked them to ask me before doing > that. > > In practice, I don't recall a triagger who closed an issue, but > someone else complained that the issue should be reopened. In a few > specific cases, the original reporter was in disagreement with > everybody else and didn't understand why their issue was not a bug and > will not be fixed, but it wasn't an issue about triaggers ;-) > > The risk of closing an issue by mistake is quite low, since the bug > remains in the database, it's trivial to reopen. Closed bugs can be > found using Google for example (which doesn't care of the bug status), > or using bugs.python.org search engine if you opt-in for closed issues > (or ignore the open/close status in a search). The topic has been > discussed previously (sorry, I don't recall where), and it was said > that it's ok to give this permission (close issues) to new triaggers. > > Now there is the question of giving the "close pull requests" > permission to new triaggers ;-) > > Victor
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/HVLB2VIGOWFFTGVKEYYHEL7PQ337Q53K/
