On Wed, 4 Dec 2019 at 09:44, Nick Coghlan <ncogh...@gmail.com> wrote: > > I have a few minor copy-editing comments, but I'll submit those as a PR to > the PEPs repo (it's nothing substantial, just a few wording clarifications, > and making sure the list of added methods is complete).
Belatedly working on those copy-editing updates, I noticed one semantic change I'd like to make to the PEP. At the moment PyType_GetModule() and PyType_GetModuleState() are specified as raising SystemError if they are passed: * a non-type object * a non-heap type * a heap type without ht_module set Raising TypeError would be more appropriate than raising SystemError, since this is really a standard case of "you passed in an object of a type the API wasn't expecting". A PR with this change (and the previously mentioned copy-editing updates) is up at https://github.com/python/peps/pull/1264 Cheers, Nick. -- Nick Coghlan | ncogh...@gmail.com | Brisbane, Australia _______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/HYUM3DZT6KM2O4SK2U2AY5AJAKABTEL5/ Code of Conduct: http://python.org/psf/codeofconduct/
