Thank you, thank you! Hopefully we can pull this one over the finish line, and it won't have to linger for another decade. :-)
On Tue, Feb 11, 2020 at 8:42 PM Zachary Ware <z...@python.org> wrote: > On Tue, Feb 11, 2020 at 9:59 PM Guido van Rossum <gu...@python.org> wrote: > > The Pull Request title is "Fix newline conversion when doctest.testfile > loads from a package whose loader has a get_data method", it looks > relatively straightforward and thorough. > > I've submitted a review; the actual code change is very simple and > straightforward, but it would be good for someone with more experience > with `importlib` (specifically setting up or mocking out a custom > `__loader__.get_data`) to take a look at the tests and make a better > suggestion than mine about how to make sure we're cleaning up > properly. > > -- > Zach > _______________________________________________ > Python-Dev mailing list -- python-dev@python.org > To unsubscribe send an email to python-dev-le...@python.org > https://mail.python.org/mailman3/lists/python-dev.python.org/ > Message archived at > https://mail.python.org/archives/list/python-dev@python.org/message/DSKFDCYGLAK32FQZL7JARMJUDQPJOG2V/ > Code of Conduct: http://python.org/psf/codeofconduct/ > -- --Guido van Rossum (python.org/~guido) *Pronouns: he/him **(why is my pronoun here?)* <http://feministing.com/2015/02/03/how-using-they-as-a-singular-pronoun-can-change-the-world/>
_______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/GC3HQH4UTXPHKFDJUDCUF3KEQVGPL42T/ Code of Conduct: http://python.org/psf/codeofconduct/
