On 2/14/06, "Martin v. Löwis" <[EMAIL PROTECTED]> wrote: > Jeremy Hylton wrote: > > The compiler in question is gcc and the warning can be turned off with > > -Wno-write-strings. I think we'd be better off leaving that option > > on, though. This warning will help me find places where I'm passing a > > string literal to a function that does not take a const char*. That's > > valuable, not insensate. > > Hmm. I'd say this depends on what your reaction to the warning is. > If you sprinkle const_casts in the code, nothing is gained.
Except for the Python APIs, we would declare the function as taking a const char* if took a const char*. If the function legitimately takes a char*, then you have to change the code to avoid a segfault. > Perhaps there is some value in finding functions which ought to expect > const char*. For that, occasional checks should be sufficient; I cannot > see a point in having code permanently pass with that option. In > particular not if you are interfacing with C libraries. I don't understand what you mean: I'm not sure what you mean by "occasional checks" or "permanently pass". The compiler flags are always the same. Jeremy _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
