Hi all, The past few weeks I've been working on adding a C extension to the reference implementation for PEP 615 (Support for the IANA Time Zone Database in the Standard Library - PEP link <https://www.python.org/dev/peps/pep-0615/>), but I've had some trouble inducing anyone to review the code <https://twitter.com/pganssle/status/1240019701356539906?s=20>. There's about 2200 lines of C code there that's passing all the tests for the pure Python implementation (which has 100% code coverage) - would anyone be interested in taking a look before I merge it into the reference implementation repo? Any little bit of review (including incremental reviews) would help:
https://github.com/pganssle/zoneinfo/pull/15 Note: You'll need to click "Load diff" on the zoneinfo_module.c file to see the actual code, because the diff is so large. The stuff that's immediately visible in the diff is the more straightforward code. I'll note that I am also happy to accept review comments about other parts of the repo, not just the C code, but the C code is a priority since errors there tend to be less forgiving. Thanks! Paul
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/MWL4Q2KRYEZ2GYK63LCBLOPJBD2FO7XY/ Code of Conduct: http://python.org/psf/codeofconduct/
